From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966296AbcHBNYa (ORCPT ); Tue, 2 Aug 2016 09:24:30 -0400 Received: from mga09.intel.com ([134.134.136.24]:51440 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965970AbcHBNPo (ORCPT ); Tue, 2 Aug 2016 09:15:44 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,460,1464678000"; d="scan'208";a="743105631" From: Baole Ni To: perex@perex.cz, tiwai@suse.com, benh@kernel.crashing.org, paulus@samba.org, mpe@ellerman.id.au, kadlec@blackhole.kfki.hu, davem@davemloft.net, m.szyprowski@samsung.com, kyungmin.park@samsung.com, k.kozlowski@samsung.com Cc: alsa-devel@alsa-project.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com, baolex.ni@intel.com, aryabinin@virtuozzo.com Subject: [PATCH 1263/1285] Replace numeric parameter like 0444 with macro Date: Tue, 2 Aug 2016 20:32:41 +0800 Message-Id: <20160802123241.2166-1-baolex.ni@intel.com> X-Mailer: git-send-email 2.9.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I find that the developers often just specified the numeric value when calling a macro which is defined with a parameter for access permission. As we know, these numeric value for access permission have had the corresponding macro, and that using macro can improve the robustness and readability of the code, thus, I suggest replacing the numeric parameter with the macro. Signed-off-by: Chuansheng Liu Signed-off-by: Baole Ni --- sound/ppc/powermac.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/ppc/powermac.c b/sound/ppc/powermac.c index 33c6be9..d6498cd 100644 --- a/sound/ppc/powermac.c +++ b/sound/ppc/powermac.c @@ -38,11 +38,11 @@ static int index = SNDRV_DEFAULT_IDX1; /* Index 0-MAX */ static char *id = SNDRV_DEFAULT_STR1; /* ID for this card */ static bool enable_beep = 1; -module_param(index, int, 0444); +module_param(index, int, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(index, "Index value for " CHIP_NAME " soundchip."); -module_param(id, charp, 0444); +module_param(id, charp, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(id, "ID string for " CHIP_NAME " soundchip."); -module_param(enable_beep, bool, 0444); +module_param(enable_beep, bool, S_IRUSR | S_IRGRP | S_IROTH); MODULE_PARM_DESC(enable_beep, "Enable beep using PCM."); static struct platform_device *device; -- 2.9.2