From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966643AbcHBNjK (ORCPT ); Tue, 2 Aug 2016 09:39:10 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:52272 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965713AbcHBNJQ (ORCPT ); Tue, 2 Aug 2016 09:09:16 -0400 X-IronPort-AV: E=Sophos;i="5.28,460,1464652800"; d="scan'208";a="376887082" Date: Tue, 2 Aug 2016 15:09:13 +0200 From: Roger Pau =?iso-8859-1?Q?Monn=E9?= To: Baole Ni CC: , , , , , , , , , Subject: Re: [PATCH 0096/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802130913.jncj2lteaie7mkep@mac> References: <20160802104021.20157-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160802104021.20157-1-baolex.ni@intel.com> User-Agent: Mutt/1.6.2-neo (2016-06-11) X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 02, 2016 at 06:40:21PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni Acked-by: Roger Pau Monné