From: Steven Rostedt <rostedt@goodmis.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Baole Ni <baolex.ni@intel.com>,
b.zolnierkie@samsung.com, tj@kernel.org, lenb@kernel.org,
x86@kernel.org, hpa@zytor.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, chuansheng.liu@intel.com,
travis@sgi.com
Subject: Re: [PATCH 0063/1285] Replace numeric parameter like 0444 with macro
Date: Tue, 2 Aug 2016 09:19:37 -0400 [thread overview]
Message-ID: <20160802131937.GB11666@home.goodmis.org> (raw)
In-Reply-To: <a4bf3836-1ffa-9f83-6e8f-998c99d5b507@cogentembedded.com>
On Tue, Aug 02, 2016 at 03:32:57PM +0300, Sergei Shtylyov wrote:
> > > static int all;
> > > -module_param(all, int, 0444);
> > > +module_param(all, int, S_IRUSR | S_IRGRP | S_IROTH);
> >
> > There's S_IRUGO for this case, no?
Sure, and honestly, I understand what 0444 is better than seeing:
S_IRUSR | S_IRGRP | SIROTH
Heck, 0444 is more understandable to me than S_IRUGO, because honestly, those
macros are just as cryptic as 0444 is. Working with Unix/Linux systems since
1991, I understand the octo numbers very well. And I'm sure most other people
do to. Any file that I'm Cc'd on here will get an automatic NAK from me.
>
> Sending 1285 patches with the same subject also was a bad idea. You need
> a subsystem/driver prefix in order to somehow differ them.
Yes, it's a very good way to be added to everyone's /dev/null folder too. Each
subsystem should have one patch that covers all its files. Not a patch per
file!
What? Is Intel now give extra bonuses for commit numbers?
Sorry, but I'm a little grumpy when my phone starts popping like a popcorn
machine while I'm having my breakfast because of these silly emails.
-- Steve
next prev parent reply other threads:[~2016-08-02 13:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 10:37 Baole Ni
2016-08-02 11:30 ` Sergei Shtylyov
2016-08-02 12:32 ` Sergei Shtylyov
2016-08-02 13:19 ` Steven Rostedt [this message]
2016-08-02 13:58 ` Marcel Holtmann
2016-08-02 18:27 ` Tejun Heo
2016-08-02 18:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802131937.GB11666@home.goodmis.org \
--to=rostedt@goodmis.org \
--cc=b.zolnierkie@samsung.com \
--cc=baolex.ni@intel.com \
--cc=chuansheng.liu@intel.com \
--cc=hpa@zytor.com \
--cc=lenb@kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tj@kernel.org \
--cc=travis@sgi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®