From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966588AbcHBNW1 (ORCPT ); Tue, 2 Aug 2016 09:22:27 -0400 Received: from lxorguk.ukuu.org.uk ([81.2.110.251]:48340 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966274AbcHBNQs (ORCPT ); Tue, 2 Aug 2016 09:16:48 -0400 Date: Tue, 2 Aug 2016 14:15:03 +0100 From: One Thousand Gnomes To: Baole Ni Cc: linux@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, chuansheng.liu@intel.com Subject: Re: [PATCH 0001/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802141503.1e8d8796@lxorguk.ukuu.org.uk> In-Reply-To: <20160802103322.13810-1-baolex.ni@intel.com> References: <20160802103322.13810-1-baolex.ni@intel.com> Organization: Intel Corporation X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2 Aug 2016 18:33:22 +0800 Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. If you are going to do this then please generate one patch per subsystem, and just do a couple of subsystems initially until everyone is happy with how it is being converted, then send out more subsystem by subsystem. Alan