From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Kevin Hilman <khilman@baylibre.com>,
Liam Girdwood <lgirdwood@gmail.com>,
alsa-devel@alsa-project.org, Sekhar Nori <nsekhar@ti.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx()
Date: Tue, 2 Aug 2016 19:11:14 +0100 [thread overview]
Message-ID: <20160802181114.GG10376@sirena.org.uk> (raw)
In-Reply-To: <8760rjj20g.wl%kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 547 bytes --]
On Tue, Aug 02, 2016 at 03:22:08AM +0000, Kuninori Morimoto wrote:
> +MODULE_AUTHOR("Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>");
> +MODULE_DESCRIPTION("ALSA SoC Simple Card Utils");
> +MODULE_LICENSE("GPL v2");
This lot is what is needed (well, just the MODULE_LICENSE).
> +MODULE_ALIAS("platform:asoc-simple-card-utils");
This is wrong, this isn't a driver but rather a library that's used by
other modules so it shouldn't have an alias. The aliases are there to
let modutils know which module to load for a device that it sees.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-08-02 18:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-01 23:36 [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Kevin Hilman
2016-08-02 1:13 ` Kuninori Morimoto
2016-08-02 2:40 ` Kevin Hilman
2016-08-02 3:22 ` [PATCH] ASoC: simple-card-utils: add missing MODULE_xxx() Kuninori Morimoto
2016-08-02 18:11 ` Mark Brown [this message]
2016-08-02 18:50 ` Kevin Hilman
2016-08-02 19:41 ` Mark Brown
2016-08-08 14:18 ` [PATCH] ASoC: simple-card: fix module load "unknown symbol" issue Sekhar Nori
2016-08-09 0:26 ` Kuninori Morimoto
2016-08-09 6:49 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160802181114.GG10376@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=khilman@baylibre.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®