From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757125AbcHBThN (ORCPT ); Tue, 2 Aug 2016 15:37:13 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:35998 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754152AbcHBTgy (ORCPT ); Tue, 2 Aug 2016 15:36:54 -0400 Date: Tue, 2 Aug 2016 15:30:06 -0400 From: Steven Rostedt To: Bart Van Assche Cc: Baole Ni , linux-kernel@vger.kernel.org, chuansheng.liu@intel.com Subject: Re: [PATCH 0269/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160802193006.GB6066@home.goodmis.org> References: <20160802105508.31682-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.6.0 (2016-04-01) X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ removed most the Cc list ] On Tue, Aug 02, 2016 at 08:14:10AM -0700, Bart Van Assche wrote: > > Hello Baole, > > Please change 0444 into S_IRUGO and 0644 into S_IRUGO | S_IWUSR. The latter > form is more compact and hence makes the code easier to read. > FYI, Linus already NACKed the entire thread. -- Steve