From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757106AbcHBVfI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 17:35:08 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:36147 "EHLO
	mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756864AbcHBVex (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 17:34:53 -0400
Date: Tue, 2 Aug 2016 23:26:50 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Tejun Heo <tj@kernel.org>
Cc: Oliver Neukum <oneukum@suse.com>, Geliang Tang <geliangtang@163.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Bhaktipriya Shridhar <bhaktipriya96@gmail.com>,
        "GeyslanG.Bem@Karyakshetra" <geyslan@gmail.com>,
        Masanari Iida <standby24x7@gmail.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Alan Stern <stern@rowland.harvard.edu>,
        Vlastimil Babka <vbabka@suse.cz>,
        Mel Gorman <mgorman@techsingularity.net>, linux-kernel@vger.kernel.org,
        linux-usb@vger.kernel.org, Saurabh Karajgaonkar <skarajga@visteon.com>
Subject: Re: [RFC] usb: host: u132-hcd: Remove deprecated
 create_singlethread_workqueue
Message-ID: <20160802212650.GE11239@dhcp22.suse.cz>
References: <20160801135036.GH13544@dhcp22.suse.cz>
 <20160801142005.GB2542@mtj.duckdns.org>
 <1470125172.30985.4.camel@suse.com>
 <20160802081801.GC12403@dhcp22.suse.cz>
 <1470132203.30985.16.camel@suse.com>
 <20160802113409.GF12403@dhcp22.suse.cz>
 <1470138288.30985.18.camel@suse.com>
 <20160802124819.GM12403@dhcp22.suse.cz>
 <1470144588.30985.23.camel@suse.com>
 <20160802190244.GH2542@mtj.duckdns.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160802190244.GH2542@mtj.duckdns.org>
User-Agent: Mutt/1.6.0 (2016-04-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue 02-08-16 15:02:44, Tejun Heo wrote:
> Hello,
> 
> On Tue, Aug 02, 2016 at 03:29:48PM +0200, Oliver Neukum wrote:
> > Apparently if that is the requirement USB will have to define its own
> > set of flags to use in such contexts. But still the calls as currently
> > executed work. Taking away WQ_MEM_RECLAIM would create danger of
> > introducing a regression. The issue with __GFP_DIRECT_RECLAIM already
> > exists and can be fixed.
> 
> Alright, let's go with WQ_MEM_RECLAIM then.

Agreed, I would just add
/*
 * TODO: make sure that no work item in the rescuer can block on an
 * allocation (so no __GF_DIRECT_RECLAIM)
 */
to all work item functions.
-- 
Michal Hocko
SUSE Labs