From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S966519AbcHBNU6 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 2 Aug 2016 09:20:58 -0400
Received: from mail.kernel.org ([198.145.29.136]:39334 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S966513AbcHBNRt (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 2 Aug 2016 09:17:49 -0400
Date: Tue, 2 Aug 2016 22:17:43 +0900
From: Masami Hiramatsu <mhiramat@kernel.org>
To: David Ahern <dsahern@gmail.com>
Cc: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>,
        linux-kernel@vger.kernel.org, ltc-kernel@rdgml.intra.hitachi.co.jp,
        masumi.moritani.ju@hitachi.com, Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Masami Hiramatsu <mhiramat@kernel.org>
Subject: Re: [PATCH 2/2 v4] perf sched: adapt TASK_STATE_TO_CHAR_STR to the
 latest kernel
Message-Id: <20160802221743.ecc77f0774d2fd1226b149fb@kernel.org>
In-Reply-To: <08486666-2be6-94d1-121e-de6f590b799e@gmail.com>
References: <1470025826-8813-1-git-send-email-tomoki.sekiyama.qu@hitachi.com>
	<1470025826-8813-2-git-send-email-tomoki.sekiyama.qu@hitachi.com>
	<08486666-2be6-94d1-121e-de6f590b799e@gmail.com>
X-Mailer: Sylpheed 3.5.0 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 1 Aug 2016 07:58:19 -0600
David Ahern <dsahern@gmail.com> wrote:

> On 7/31/16 10:30 PM, Tomoki Sekiyama wrote:
> > Update TASK_STATE_TO_CHAR_STR macro to one from sched.h in the latest
> > kernel, where 'N' and 'n' are introduced, 'X' and 'Z' are swapped.
> >
> > Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama.qu@hitachi.com>
> > Fixes: cdce9d738b91e ("perf sched: Add sched latency profiling")
> 
> Wrong Fixes tag for this change.
> 
> This is really an update based on kernel changes, the last one being 
> 7dc603c9028ea.

Except for the above mistake, I'm also OK for the code.

Thanks,

> 
> 
> > Cc: Jiri Olsa <jolsa@kernel.org>
> > Cc: David Ahern <dsahern@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
> > Cc: Masami Hiramatsu <mhiramat@kernel.org>
> > ---
> > Changes from v3:
> >   Added Fixes:
> >   Split patch into 2 pieces.
> >
> >  tools/perf/builtin-sched.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/builtin-sched.c b/tools/perf/builtin-sched.c
> > index ce9bef6..5776263 100644
> > --- a/tools/perf/builtin-sched.c
> > +++ b/tools/perf/builtin-sched.c
> > @@ -70,7 +70,7 @@ struct sched_atom {
> >  	struct task_desc	*wakee;
> >  };
> >
> > -#define TASK_STATE_TO_CHAR_STR "RSDTtZXxKWP"
> > +#define TASK_STATE_TO_CHAR_STR "RSDTtXZxKWPNn"
> >
> >  enum thread_state {
> >  	THREAD_SLEEPING = 0,
> >
> 
> Acked-by: David Ahern <dsahern@gmail.com>


-- 
Masami Hiramatsu <mhiramat@kernel.org>