From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755101AbcHCGqP (ORCPT ); Wed, 3 Aug 2016 02:46:15 -0400 Received: from mail.skyhub.de ([78.46.96.112]:43301 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbcHCGpn (ORCPT ); Wed, 3 Aug 2016 02:45:43 -0400 Date: Wed, 3 Aug 2016 08:44:43 +0200 From: Borislav Petkov To: Lukasz Odzioba Cc: linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, dougthompson@xmission.com, mchehab@kernel.org, tony.luck@intel.com, hubert.chrzaniuk@intel.com, lukasz.anaczkowski@intel.com Subject: Re: [PATCH 1/1] EDAC, sb_edac: Fix channel reporting on Knights Landing Message-ID: <20160803064443.GA31099@nazgul.tnic> References: <1469231089-22837-1-git-send-email-lukasz.odzioba@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1469231089-22837-1-git-send-email-lukasz.odzioba@intel.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jul 23, 2016 at 01:44:49AM +0200, Lukasz Odzioba wrote: > On Intel Xeon Phi Knights Landing processor family the channels > of memory controller have untypical arrangement - MC0 is mapped to > CH3,4,5 and MC1 is mapped to CH0,1,2. This causes EDAC driver to > report the channel name incorrectly. > > We missed this change earlier, so the code already contains > similar comment, but the translation function is incorrect. > > Without this patch: > errors in DIMM_A and DIMM_D were reported in DIMM_D > errors in DIMM_B and DIMM_E were reported in DIMM_E > errors in DIMM_C and DIMM_F were reported in DIMM_F > > Fixes: d0cdf9003140 ("sb_edac: Add Knights Landing (Xeon Phi gen 2) support") > Signed-off-by: Lukasz Odzioba > Signed-off-by: Hubert Chrzaniuk What is that SOB supposed to mean? -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --