From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758744AbcHDPEc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 4 Aug 2016 11:04:32 -0400
Received: from bombadil.infradead.org ([198.137.202.9]:34496 "EHLO
	bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1758713AbcHDPE3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 4 Aug 2016 11:04:29 -0400
Date: Thu, 4 Aug 2016 16:43:25 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: David Carrillo-Cisneros <davidcc@google.com>
Cc: linux-kernel@vger.kernel.org, "x86@kernel.org" <x86@kernel.org>,
        Ingo Molnar <mingo@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
        Paul Turner <pjt@google.com>, Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/3] perf/core: introduce pmu_event_flags and
 PMUEF_READ_CPU_PKG
Message-ID: <20160804144325.GP6862@twins.programming.kicks-ass.net>
References: <1470105895-71379-1-git-send-email-davidcc@google.com>
 <1470105895-71379-3-git-send-email-davidcc@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470105895-71379-3-git-send-email-davidcc@google.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Aug 01, 2016 at 07:44:54PM -0700, David Carrillo-Cisneros wrote:
> +++ b/include/linux/perf_event.h
> @@ -681,9 +681,21 @@ struct perf_event {
>  #endif
>  
>  	struct list_head		sb_list;
> +
> +	/* Per-event flags to generic code set by PMU. */
> +	int				pmu_event_flags;
> +

It appears to me we already have group_flags and attach_state which both
are serialized by ctx->lock.

Could we maybe merge the lot into one flags field?