From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758776AbcHDPsl (ORCPT ); Thu, 4 Aug 2016 11:48:41 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:48994 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758680AbcHDPsj (ORCPT ); Thu, 4 Aug 2016 11:48:39 -0400 Date: Thu, 4 Aug 2016 16:48:14 +0100 From: Mark Brown To: Cristian Birsan Cc: nicolas.ferre@atmel.com, ludovic.desroches@atmel.com, alexandre.belloni@free-electrons.com, boris.brezillon@free-electrons.com, ce3a@gmx.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20160804154814.GA10383@sirena.org.uk> References: <1470322558-7501-1-git-send-email-cristian.birsan@microchip.com> <1470322558-7501-2-git-send-email-cristian.birsan@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="PEIAKu/WMn1b1Hv9" Content-Disposition: inline In-Reply-To: <1470322558-7501-2-git-send-email-cristian.birsan@microchip.com> X-Cookie: Don't hit the keys so hard, it hurts. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/2] regmap: Add a function to check if a regmap register is cached X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --PEIAKu/WMn1b1Hv9 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Aug 04, 2016 at 05:55:57PM +0300, Cristian Birsan wrote: > +bool regmap_cached(struct regmap *map, unsigned int reg) > +{ > + if (map->cache == REGCACHE_NONE) > + return false; > + > + if (!map->cache_ops) > + return false; > + > + if (map->max_register && reg > map->max_register) > + return false; > + > + return true; > +} As Lars said this isn't actually checking if the register is cached. To do this you need to modify the output code to check if there's a value cached and try a read if there is one instead. --PEIAKu/WMn1b1Hv9 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXo2O9AAoJECTWi3JdVIfQShIH/3KZNv6fK6c70L2BdnKR2bNx oyLjWPZ57+xN49W84zH8dB/24cLBDplEUCfUFl1d0LXhpOBOLU2bwg2s6ea/Iw8Y SP6MxSLqoh2LafYOAkEAppoc/+p8i06L4AOfkbuYmSOFusZHGNOVdmWZ6yMibpcT YSmQh2T6UeVpMNsywzHQ2nsRQLE8Zvy/JKv3JKi2sX7W93uDu+KD+BoC6bXG/SuL GgcdhGyCQ3HNDUJDq6kVg3DRRjKfdeaKATDh1+HwUm6Wgk5ylo+qsWtjVgRXdY9Z GXOPsQ2BlCKrB6Lqu1OnabYeIbj9cytzIIYix92H6eJeBAS12HKqWmelkGIthpY= =fFsV -----END PGP SIGNATURE----- --PEIAKu/WMn1b1Hv9--