From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965677AbcHDU1J (ORCPT ); Thu, 4 Aug 2016 16:27:09 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:50744 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759004AbcHDU1H (ORCPT ); Thu, 4 Aug 2016 16:27:07 -0400 Date: Thu, 4 Aug 2016 21:26:46 +0100 From: Mark Brown To: Cristian Birsan Cc: nicolas.ferre@atmel.com, ludovic.desroches@atmel.com, alexandre.belloni@free-electrons.com, boris.brezillon@free-electrons.com, ce3a@gmx.de, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Message-ID: <20160804202646.GH10383@sirena.org.uk> References: <1470322558-7501-1-git-send-email-cristian.birsan@microchip.com> <1470322558-7501-3-git-send-email-cristian.birsan@microchip.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vSsTm1kUtxIHoa7M" Content-Disposition: inline In-Reply-To: <1470322558-7501-3-git-send-email-cristian.birsan@microchip.com> X-Cookie: Don't hit the keys so hard, it hurts. User-Agent: Mutt/1.6.0 (2016-04-01) X-SA-Exim-Connect-IP: 2a01:348:6:8808:fab::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] regmap: debugfs: Add support for dumping write only device registers X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vSsTm1kUtxIHoa7M Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Aug 04, 2016 at 05:55:58PM +0300, Cristian Birsan wrote: > Add support for dumping write only device registers in debugfs. This is > useful for audio codecs that have write only registers (like WM8731). > The logic that decides if a value can be printed is moved to > regmap_printable() function to allow for easier future updates. Please check your CC list when sending things upstream - try to ensure that people you're sending patches to are relevant to the patch. Maintainers often get lots of mail and having to sort out mail that's not really relevant to them can make it easier for relevant mail to get missed. > +static bool regmap_printable(struct regmap *map, unsigned int reg) > +{ > + if (regmap_precious(map, reg)) > + return false; > + > + if (!regmap_readable(map, reg) && !regmap_cached(map, reg)) > + return false; > + > + return true; > +} This only has one user... > for (i =3D start_reg; i <=3D to; i +=3D map->reg_stride) { > - if (!regmap_readable(map, i)) > + if (!regmap_readable(map, i) && !regmap_cached(map, i)) > continue; > =20 =2E..though it could have more. > - ret =3D regmap_read(map, i, &val); > + if (regmap_readable(map, i)) > + ret =3D regmap_read(map, i, &val); > + else > + ret =3D regcache_read(map, i, &val); > + I don't understand this change, a read will go to cache anyway. --vSsTm1kUtxIHoa7M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJXo6UFAAoJECTWi3JdVIfQhrIH/1famu7GT30iBcKcE2dqFvZG jC8ufK5mCFAv2ht5CrBqv4P3wMY0NZ2U9b0bC5eJgoZ462hjO/Ok3rvrcBfy+6kp FM1AFw466cOepQzwEB5VEbOdznWJZHfsw8S+HGRU8NmVL/my61aEUGaGhyxNZ12S jbMoKIzP4xGp5TN3D/vTuXam/6h9FEYggLbpB/3B2Jyl/fIArUw1/YZpNlg9FyIA M4LvNArBEQTKRvYkR5dOr4wrOXfG1WI4bY+oRbtDrfyTyrWrVh0mkxIGU57TLl0b dKFYKZSfUzBRmVDNPbf0E5KxX0+MTI4/NaL2bPWqc2aIiOSYRdptKu/jXFR2ReA= =Gb7R -----END PGP SIGNATURE----- --vSsTm1kUtxIHoa7M--