From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759301AbcHDXMj (ORCPT ); Thu, 4 Aug 2016 19:12:39 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:56771 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752708AbcHDXMh (ORCPT ); Thu, 4 Aug 2016 19:12:37 -0400 Date: Fri, 5 Aug 2016 00:01:25 +0100 From: Russell King - ARM Linux To: Jose Abreu Cc: dri-devel@lists.freedesktop.org, Carlos Palminha , Archit Taneja , David Airlie , Fabio Estevam , Daniel Vetter , Takashi Iwai , Vladimir Zapolskiy , Thierry Reding , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3 v3] drm: bridge/dw-hdmi: Move edid reading to .detect() callback Message-ID: <20160804230125.GZ1041@n2100.armlinux.org.uk> References: <1bbffb944fb9ce0363f5544db31baf2a911c1c55.1470306826.git.joabreu@synopsys.com> <20160804104738.GR1041@n2100.armlinux.org.uk> <57A349E8.5040400@synopsys.com> <20160804143102.GU1041@n2100.armlinux.org.uk> <57A357D1.1070900@synopsys.com> <20160804150443.GW1041@n2100.armlinux.org.uk> <57A377AE.5060208@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <57A377AE.5060208@synopsys.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 04, 2016 at 06:13:18PM +0100, Jose Abreu wrote: > Hi Russell, > > So, I didn't use framebuffer console but used X instead and it is > working as it should. I think we can drop this patch. I am now > making interoperability with DVI and I am facing the following > scenario: > - I start the driver > - An EDID is sent which tells the driver that HDMI is NOT > supported; > - The driver configures itself to a DVI mode; > > Until this point everything is working as it should. But: > > - Now I send an EDID which tells the driver that HDMI is > supported; > - As the EDID has the same preferred mode the user will not > reconfigure the mode and there will be no change to HDMI mode. The EDID should still be read, but as you say, userspace doesn't take any action because it sees that the mode parameters are still the same, as you have identified. > The missing change to HDMI mode will cause the test to fail. The > workaround that I am using is to reconfigure to another video > mode and then configure to the preferred one but I think this > could be fixed in the driver, right? This one is extremely awkward - to fix it, we would need to check to see whether we reconfigure the hardware each time we read the EDID, and I don't think that's a particularly nice thing to do. I'd like to hear what other DRM developers think about this issue. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.