From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965554AbcHEAA6 (ORCPT ); Thu, 4 Aug 2016 20:00:58 -0400 Received: from ex13-edg-ou-001.vmware.com ([208.91.0.189]:16217 "EHLO EX13-EDG-OU-001.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965093AbcHEAA4 (ORCPT ); Thu, 4 Aug 2016 20:00:56 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=syeh@vmware.com; Date: Thu, 4 Aug 2016 17:00:45 -0700 From: Sinclair Yeh To: Baole Ni CC: , , , , , , , , , , , Subject: Re: [PATCH 0215/1285] Replace numeric parameter like 0444 with macro Message-ID: <20160805000044.GA4056@promb-2n-dhcp351.eng.vmware.com> References: <20160802105025.28089-1-baolex.ni@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20160802105025.28089-1-baolex.ni@intel.com> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [208.91.1.34] X-ClientProxiedBy: BY1PR0501CA0002.namprd05.prod.outlook.com (10.162.139.12) To DM5PR05MB3244.namprd05.prod.outlook.com (10.173.220.10) X-MS-Office365-Filtering-Correlation-Id: 1a6a8cc4-51d2-4865-0c82-08d3bcc3915d X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3244;2:Qj++ZnOf7IWTuz24DYAH2tO2ktD2MLpsioOAYXf2FGBoDHzj6kShNvPRgZrisdy6P9zwCN3Zzm7a0UgQbSnEGSv+8A9E2ODoUUyBG7fQ6wWmo6cd+hOxP2loSHeNhZyuBFxokvaC8lHNCjnpqQoEIbRLcli/0bVKXi1755lMCWR+yuoNSN25CEKxkqkw2M+s;3:6Szpz+ODG5shIg+RBU+pHDciNTK6aoSYDE4BQCtRg/+5DUZCJLk0q+IJV6WUjaeJwv8M//VuMfzKPZvpD7JZw5dqXrrh4iXNpgRrC4h/yW0cN/xv312OSMJWJ697cQE2;25:Dmqd4haIAhTIdY0b00aWvnyY2dPPnoAMSC58K38avhEtl/SZiTt/7q4gtwqR3hCCvF5Xf3lxNKf+K1vcN1o2AUWzuQql1sW1I1sJ9fVLJb941WzwuNARvXWOSVn6kKw9LE1buaAWIMOiY8+SALuZaaOjvpo0XvlqZb9l70bpy3ld67acVGSvmTOLCk3tmBTTajcbBN2K9YamC2PC1nDl9nCnAyCRJJDwF+ncsPLV0byj3s1bG2u4+lPeXTsTj1Iq83aiWwsYf8jMAmnZfDCRVliOR1DjEYtcOq/AVUTzNVfv2V6THJR6dHQTS64k0bCOsizX9IVRb4pFS6XMoE4EfgjbqJzp+bjuYx+Ek2DYV31m3Gk+8F79URTcl3RUhqOSVwr5pOMvSytWo0aJr/T/QIc1XKjcw2D6Xv5mxdx6CYI= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM5PR05MB3244; X-LD-Processed: b39138ca-3cee-4b4a-a4d6-cd83d9dd62f0,ExtAddr X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3244;31:BeTq8lswkXO9tqUOIW9KABk7MULzy3nLWif+01B6EHMCZRJBVJuB60jPZRRAy6FshpU74uLXJ0uzOetk/D0M92myCudYBUxsyA9Df79kPRdXN1BzwWn/9Kqjdz11fI3LiJ4Eh6DHZGY7Yc9pOU3oMHvE7z+MJ8J6rq09Iv3RFngsZqfJhiolKU9Ttea9oUxCHKGibRzj5fk8bKVhpZvGqQvFzp8rhAYdKvUe6Qw19U8=;20:0i/Yfu/eVbedEAU2Sa8wfy0Q7/NZh33j2FOSTZIeQGm3Zu5cmvZwTGov0oEFv2fQo8A1lfLsZpc/by1L24pwmUmU2J4s3YP5A1RlW4aaCVRgkDZ4UvVBqlBLdKGmnSh9+wc9TbqNF9G7K4FnHQ0FEZ8d+MK4t+nfpIQhZrbmWLsQsKK4BXl6IZJ8O/ut2EeFMl9PrSkjwu5c9DqL+eH5BREvac/x5MZ7VnsvYCtKKE8kKg2M12AxuiYz7Whda+qQ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(61668805478150)(788757137089)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DM5PR05MB3244;BCL:0;PCL:0;RULEID:;SRVR:DM5PR05MB3244; X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3244;4:NvU4y0B1AA9TUHkcJMwsiP9R0hOn36FNoeqyK+uEJA1kVA/wgAHYjy+LK0ii0CZ4Unuyyo1MLYBFZK411n+5lLhZXkGwdgbV2e+xeg4WGRzY9c5Hf1LN+Xe3B1k4dGZrZNu4BbeNMR9gnR2jmXKKsTcd88TF55mgYbH9PocstZC6l4GS/3eeT/A4DE2pEpdMXCZKK9JXNPiGSYA6EVwNkZnDMTxRyPTP01HXDU6R/GGU7DCwUakEeinE9WpftGq/rX5VdH2uM0/GxzkdyFd2ORwAtxmO8HyQvUc3qyLtemIg61PJCDRnv6JrGyqe2h9x5YLJoPyVF/gR3aqBMlAYCOFUMlzjaXtmq9reNhumb4BgANSqRiThGkyCheLnO3QDzZ6GedZRHdBwPPnQVL1GFn/gS7Wm1zKwpEMZNP4RqSmBepVk85TTJkXmGCnKuc0UZyHdUTO9gh8BNVQDySWjIsNIM8ei7ouct1SiEknHsNs= X-Forefront-PRVS: 0025434D2D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(189002)(24454002)(7846002)(86362001)(7736002)(46406003)(305945005)(110136002)(2906002)(23726003)(97756001)(586003)(50986999)(76176999)(33656002)(106356001)(8676002)(105586002)(97736004)(4001350100001)(42186005)(4326007)(101416001)(189998001)(54356999)(1076002)(7416002)(50466002)(19580405001)(6116002)(68736007)(19580395003)(66066001)(3846002)(83506001)(47776003)(77096005)(92566002)(81166006)(81156014)(2950100001)(8666005)(7099028)(18370500001)(7059030);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR05MB3244;H:promb-2n-dhcp351.eng.vmware.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DM5PR05MB3244;23:w4jrbPf4Z42hZ/e0XxCI+BEWIyjUK13aSAxFOWVLm?= =?us-ascii?Q?4dAkaD2ZR+a+bzBFZirpF4lTh0rCfmuyTt08yKJiB9BnEn9rh0cKXovEIWiU?= =?us-ascii?Q?O1MHtPb/lIGTkzWLHUH2W1KV+93jn4Cpheq2uGd7Q94bjc/qSz0IqjSYOZWT?= =?us-ascii?Q?5NfpkTuO9AwXC+Qs63o8sRMJQ3YGctvQUT2bkobuvUE2PINWvEme2fWJbnyv?= =?us-ascii?Q?wMgwWhTUBuEWPxXIs2aISWBxeRkqE/rEQ7VdqfD2e2JVq5o0/eDokIFCGDzp?= =?us-ascii?Q?MwdYmtUmw0HJ1W891fJpSfOsxjNAbIwVwVciFsWmAqFYuKdmmYPMLeKaX5d+?= =?us-ascii?Q?m7WIlWRjWc5C/X8gE0I4Nt5NOikfq4u1zADuipz3IJWjnvhBGO94+8G8MhZy?= =?us-ascii?Q?2AuV5OLo0JgM9ZgYs/AEn+sCTd+/vkDx5tmzmEt6ASbHZHH/GLCu7eCF03HQ?= =?us-ascii?Q?jnz0a1VSi+7UhJ2jHkaR//krViBYjbw2VFnWleEiyBN7UYvaq3JlF+WldVCV?= =?us-ascii?Q?nhakshL8gFf0rybDXcybMJlPoXG/z6F2Lz/NiwHOhDqT0YijEYYPMZHa+s1b?= =?us-ascii?Q?iSQ6sxr44vqC1Eb4FBRG9uXxOixzdpe/E5e4RoSZX7uvfAd75Fr9/Pcf9IQt?= =?us-ascii?Q?mkIw/vb0FSj+/r4oqz/I1LXR+lsXKDRdXlBk/4Z5n7tyXsIrlkEPHelmPJyS?= =?us-ascii?Q?SQLk+8MZZ3jNyNBF9gKlT0xsXJOW6Bez8o8ZqQurwFjYkBwiSpbxMOvXjShW?= =?us-ascii?Q?gH7uigLnv5BDFSqJvzpjKkQB8RLLCAARKYV5e+GAYgFJyZX0a5l1Av957JVk?= =?us-ascii?Q?ZxVOscEvZnBpaSZxymgkhOE4EcLtFqRPJGBvGbd/f9pGm9uTKSvXoQPiQ2R+?= =?us-ascii?Q?fexLZB9ud6begt9RtTEbXHyYbFf50ukKH0qd2FFvEQwZXRtKvnSTtWSHutZ4?= =?us-ascii?Q?EJ7lQXi578HJCuqLqcRm4beM2O4FbkMn7k2/Uiz5G/hwhzB5uQzbW8wot0qt?= =?us-ascii?Q?3lSGUuWJF/2Y0vL8anVBC2EmubFnjLdtj3miCOyRan+UcdNJM3EeUQaCDVcm?= =?us-ascii?Q?+zi+QiBKBz3IxZOD+PDChWVtWEsxbEz3uSKSkK2V98PQ8A1lTg0QI916uLSL?= =?us-ascii?Q?aPdmG4eb3gMnLQ1uNOs0+ZaW/aC+WuzIPkdIVQ489sm/DxHNkbF8UPjkI7Np?= =?us-ascii?Q?z6+kb+O5B4YKGzOhMrz6mtEeMlO6I95f2oJ?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3244;6:nJcPacw09NhoOGjjt85iYNE2it48/YnrqYToq3O5Phu8OjwL0JzuXY0XNmu34vIwe7OmSamB9wjO4qFcxZA+K0l5HMImzW/pRQNpBBHcdIem0DHXB8P0y4MGNUsYq4NHWzuYnRexrrA3xD5whCKgwz/Y2lH01Cpqs0VSSlniD1gpQo1mRGHwmk4QtnrG7OZHSxVDA/wpGZ/rGncT8fr8sA7His8mfaon2TMOPI8m19D3pCwLCxjdncqbisiipz5mi/dtJxw+cR7mNmwR6Jdw20s4N81LlAGBpj/envhm+e8=;5:gV+QCoPGwyL0VI8n2bFHR0qwzh7cTXENR1c/OngXRNxnopVYZ4HNfm8EaO0AbUSov4hcYd7d8MyMD2LbaFCqZIPvhz3zS0o+aR6i3z7p5o2HN/ECDkWagEye9+ePvSpecuS4ww8+4GHqNolukGTLtw==;24:dYSqkjyYkFe+74JyBYVb9Vkz9y6lxl4O+BqbcbL8cg0/bd3qWxnrWQwIpA2B82jwQr84Dc+0DcJG1TQr8cdlLe0C/GkLViHDHd4+L1LNEm0=;7:bFWET8u1XfgpNcsc/MUshCytZzOW03sb5irRM9u1/9A7NRayU+53pvO0KzNBvHovIOZM6PuAgOjJhMnCZcmV90bpVPtZCB1bGibUePfJVPo2u4lyMh8W45aTLFIc8Z5SQbjAs7OShFkvmmGAOBuf23np4bLOIzvHZlxs0aVzil8s6z6hVStv5Z1P5/j6uw9T+A+r9oT8dgJYv7juTqlwRyrNeBbn5ghkg4631nlJXqXiRlWWhtXRMejKXFmZyaau SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM5PR05MB3244;20:9+DbMc+Kg+B1OL4VZJkJKFELRlNmkJXPLWPz0PkOUmQPTqEAWFMsMfhs2IudrIrV5b+jGjclZG5RotlyHThnTsNCMxKPO4DfpKuXPpExlZo9ufKpaxe56IwsmXHAuoISRiz89eA5kSgQD/ryyN1vy5ZRyg8r8Fr5rxY2rsBYVi0= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2016 00:00:52.2071 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR05MB3244 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Reviewed-by: Sinclair Yeh On Tue, Aug 02, 2016 at 06:50:25PM +0800, Baole Ni wrote: > I find that the developers often just specified the numeric value > when calling a macro which is defined with a parameter for access permission. > As we know, these numeric value for access permission have had the corresponding macro, > and that using macro can improve the robustness and readability of the code, > thus, I suggest replacing the numeric parameter with the macro. > > Signed-off-by: Chuansheng Liu > Signed-off-by: Baole Ni > --- > drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > index 9fcd820..b8e5d3d 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -240,15 +240,15 @@ static int vmwgfx_pm_notifier(struct notifier_block *nb, unsigned long val, > void *ptr); > > MODULE_PARM_DESC(enable_fbdev, "Enable vmwgfx fbdev"); > -module_param_named(enable_fbdev, enable_fbdev, int, 0600); > +module_param_named(enable_fbdev, enable_fbdev, int, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(force_dma_api, "Force using the DMA API for TTM pages"); > -module_param_named(force_dma_api, vmw_force_iommu, int, 0600); > +module_param_named(force_dma_api, vmw_force_iommu, int, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(restrict_iommu, "Try to limit IOMMU usage for TTM pages"); > -module_param_named(restrict_iommu, vmw_restrict_iommu, int, 0600); > +module_param_named(restrict_iommu, vmw_restrict_iommu, int, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(force_coherent, "Force coherent TTM pages"); > -module_param_named(force_coherent, vmw_force_coherent, int, 0600); > +module_param_named(force_coherent, vmw_force_coherent, int, S_IRUSR | S_IWUSR); > MODULE_PARM_DESC(restrict_dma_mask, "Restrict DMA mask to 44 bits with IOMMU"); > -module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, 0600); > +module_param_named(restrict_dma_mask, vmw_restrict_dma_mask, int, S_IRUSR | S_IWUSR); > > > static void vmw_print_capabilities(uint32_t capabilities) > -- > 2.9.2 >