From: Mark Brown <broonie@kernel.org>
To: Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Cc: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org,
Support Opensource <support.opensource@diasemi.com>,
linux-kernel@vger.kernel.org, c.huber@bct-electronic.com
Subject: Re: [alsa-devel] [PATCH 4/4] ASoC: da7213: Improve 32KHz mode PLL locking
Date: Fri, 5 Aug 2016 11:30:01 +0100 [thread overview]
Message-ID: <20160805103001.GP10383@sirena.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1608051102420.11835@pmeerw.net>
[-- Attachment #1: Type: text/plain, Size: 559 bytes --]
On Fri, Aug 05, 2016 at 11:04:51AM +0200, Peter Meerwald-Stadler wrote:
> these registers cannot not found in the datasheet;
> maybe add descriptive #defines in da7213.h
> > + snd_soc_write(codec, 0xF0, 0x8B);
> > + snd_soc_write(codec, 0xF2, 0x03);
> > + snd_soc_write(codec, 0xF0, 0x00);
It is very common for chips to have undocumented write sequences that
make tweaks based on test registers that are deliberately not
documented. This looks like such a case, I'd imagine that register 0xf0
is a test key and 0xf2 contains a value being tweaked.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-08-05 10:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 14:35 [PATCH 0/4] ASoC: da7213: Device clocking updates and fixes Adam Thomson
2016-08-04 14:35 ` [PATCH 1/4] ASoC: da7213: Default to 64 BCLKs per WCLK to support all formats Adam Thomson
2016-08-08 7:52 ` [alsa-devel] " Peter Meerwald-Stadler
2016-08-04 14:35 ` [PATCH 2/4] ASoC: da7213: Improve driver efficiency with regards to MCLK usage Adam Thomson
2016-08-08 7:43 ` [alsa-devel] " Peter Meerwald-Stadler
2016-08-04 14:35 ` [PATCH 3/4] ASoC: da7213: Refactor sysclk(), pll() functions to improve handling Adam Thomson
2016-08-08 7:42 ` [alsa-devel] " Peter Meerwald-Stadler
2016-08-08 10:32 ` Adam Thomson
2016-08-04 14:35 ` [PATCH 4/4] ASoC: da7213: Improve 32KHz mode PLL locking Adam Thomson
2016-08-05 9:04 ` [alsa-devel] " Peter Meerwald-Stadler
2016-08-05 10:30 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160805103001.GP10383@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=c.huber@bct-electronic.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=pmeerw@pmeerw.net \
--cc=support.opensource@diasemi.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®