From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424600AbcHETPl (ORCPT ); Fri, 5 Aug 2016 15:15:41 -0400 Received: from smtprelay0213.hostedemail.com ([216.40.44.213]:46355 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S939044AbcHETPd (ORCPT ); Fri, 5 Aug 2016 15:15:33 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::,RULES_HIT:41:355:379:541:560:599:800:960:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3867:3870:3871:3872:3873:3874:4321:4362:5007:6238:6261:7875:9040:10004:10400:10848:10903:10967:11026:11232:11473:11658:11914:12043:12438:12517:12519:12555:12663:12740:13069:13255:13311:13357:13439:14181:14659:14721:21080:30034:30054:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: hill84_4d284fee52d28 X-Filterd-Recvd-Size: 1946 Date: Fri, 5 Aug 2016 15:15:28 -0400 From: Steven Rostedt To: Arnaldo Carvalho de Melo Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton Subject: Re: [PATCH 2/4] tools lib traceevent: Use USECS_PER_SEC instead of hardcoded number Message-ID: <20160805151528.216cf1c5@gandalf.local.home> In-Reply-To: <20160805183655.GA3789@kernel.org> References: <20160209204013.951400594@goodmis.org> <20160209204237.006667394@goodmis.org> <20160302122004.GI3604@kernel.org> <20160805141942.07469948@gandalf.local.home> <20160805183655.GA3789@kernel.org> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Aug 2016 15:36:55 -0300 Arnaldo Carvalho de Melo wrote: > [acme@jouet linux]$ cat tools/include/linux/time64.h > #ifndef _TOOLS_LINUX_TIME64_H > #define _TOOLS_LINUX_TIME64_H > > #define MSEC_PER_SEC 1000L > #define USEC_PER_MSEC 1000L > #define NSEC_PER_USEC 1000L > #define NSEC_PER_MSEC 1000000L > #define USEC_PER_SEC 1000000L > #define NSEC_PER_SEC 1000000000L > #define FSEC_PER_SEC 1000000000000000LL > > #endif /* _TOOLS_LINUX_TIME64_H */ > [acme@jouet linux]$ > > So the header to include is the same as in the kernel, the constants as > well. We can go on adding more stuff from include/linux/time64.h as > tools use it. OK, can you modify the scripting-engines/trace-event-*.c to use that too. I'm going to move the macros locally into event-parse.c, as I work to make that ready to be a separate library. Thanks! -- Steve