From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752113AbcHHCPC (ORCPT ); Sun, 7 Aug 2016 22:15:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58760 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884AbcHHCPB (ORCPT ); Sun, 7 Aug 2016 22:15:01 -0400 Date: Mon, 8 Aug 2016 10:14:51 +0800 From: Dave Young To: Zhou Wenjian Cc: linux-kernel@vger.kernel.org, d.hatayama@jp.fujitsu.com, kexec@lists.infradead.org, bhe@redhat.com Subject: Re: [PATCH v3 1/2] Documentation: kdump: remind user of nr_cpus Message-ID: <20160808021451.GA5375@dhcp-128-65.nay.redhat.com> References: <1470185952-23477-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470185952-23477-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Mon, 08 Aug 2016 02:15:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/03/16 at 08:59am, Zhou Wenjian wrote: > v2->v3: add description of nr_cpus. > v1->v2: change nr_cpus to maxcpus > > nr_cpus can help to save memory. So we should remind user of it. > > Signed-off-by: Zhou Wenjian > --- > Documentation/kdump/kdump.txt | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/kdump/kdump.txt b/Documentation/kdump/kdump.txt > index 88ff63d..4aa194e 100644 > --- a/Documentation/kdump/kdump.txt > +++ b/Documentation/kdump/kdump.txt > @@ -393,6 +393,8 @@ Notes on loading the dump-capture kernel: > * We generally don' have to bring up a SMP kernel just to capture the > dump. Hence generally it is useful either to build a UP dump-capture > kernel or specify maxcpus=1 option while loading dump-capture kernel. > + Note, though maxcpus always works, we should replace it by nr_cpus to > + save memory if supported by the current ARCH, such as x86. Can you replace "we" with "you" in both these patches? Thanks Dave