From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752051AbcHHHLf (ORCPT ); Mon, 8 Aug 2016 03:11:35 -0400 Received: from mail.skyhub.de ([78.46.96.112]:47719 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbcHHHLe (ORCPT ); Mon, 8 Aug 2016 03:11:34 -0400 Date: Mon, 8 Aug 2016 09:11:11 +0200 From: Borislav Petkov To: York Sun Cc: linux-edac@vger.kernel.org, morbidrsa@gmail.com, oss@buserror.net, stuart.yoder@nxp.com, Doug Thompson , mchehab@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1 Message-ID: <20160808071111.GB20800@nazgul.tnic> References: <1470351518-22404-1-git-send-email-york.sun@nxp.com> <1470351518-22404-4-git-send-email-york.sun@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1470351518-22404-4-git-send-email-york.sun@nxp.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 04, 2016 at 03:58:28PM -0700, York Sun wrote: > On e500v1, read fault exception enable (RFXE) controls whether > assertion of core_fault_in causes a machine check interrupt. > Assertion of core_fault_in can result from uncorrectable data > error, such as an L2 multibit ECC error. It can also occur from > a system error if logic on the integrated device signals a fault > for nonfatal errors. RFXE bit is cleared out of reset, and should > be left clear for normal operation. Assertion of core_fault_in does > not cause a machine check. > > RFXE is set specifically for RIO (Rapid IO) and PCI for book E to > catch the errors by machine check. With this bit set, EDAC driver > can't get the interrupt in case of uncorrectable error. So this > bit is cleared in favor of EDAC. However, the benefit of catching > such uncorrectable error doesn't outweight the other errors which > may hang the system. Beside, e500v2 has different errors maksed > by RFXE, and e500mc doesn't support this bit. It is more reasonable > to leave RFXE as is in EDAC driver, and leave the uncorrectable > errors triggering machine check for e500v1. Very nice, thanks for expanding it! Two final remarks: - please use a spell checker - now, what happens if you leave RFXE clear and mpc85xx_edac gets the error? Is it going to do proper error handling of the uncorrectable error or are we better off handling the error in the #MC interrupt handler? IOW, is mpc85xx_edac well equipped to handle those multibit errors or should we leave the current setting as is? Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --