From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752704AbcHHNnH (ORCPT ); Mon, 8 Aug 2016 09:43:07 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50036 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752307AbcHHNnF (ORCPT ); Mon, 8 Aug 2016 09:43:05 -0400 Date: Mon, 8 Aug 2016 15:43:15 +0200 From: Greg KH To: dirk.eibach@gdsys.cc Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, jslaby@suse.com, jringle@gridpoint.com Subject: Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop Message-ID: <20160808134315.GA11190@kroah.com> References: <1470663136-26269-1-git-send-email-dirk.eibach@gdsys.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470663136-26269-1-git-send-email-dirk.eibach@gdsys.cc> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 08, 2016 at 03:32:15PM +0200, dirk.eibach@gdsys.cc wrote: > From: Dirk Eibach > > sc16is7xx_port_irq() is laid out as an endless loop. It will exit only > when there is no more interrupt left to service. This not common > practice. > In our case it lead to some strange hangup situation when there was an > unexpected XOFF-interrupt that could not be handled. > So let's service interrupts only once and report XOFF-interrupts that > should never happen since they are never enabled. > > Signed-off-by: Dirk Eibach > > Conflicts: > drivers/tty/serial/sc16is7xx.c Why are these 2 lines in here?