From: Greg KH <gregkh@linuxfoundation.org>
To: Tejun Heo <tj@kernel.org>
Cc: serge.hallyn@ubuntu.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org, kernel-team@fb.com, hannes@cmpxchg.org,
lizefan@huawei.com
Subject: Re: [PATCHSET] kernfs, cgroup: make kernfs_path*() and cgroup_path*() behave in strlcpy() style
Date: Tue, 9 Aug 2016 10:18:19 +0200 [thread overview]
Message-ID: <20160809081819.GB10279@kroah.com> (raw)
In-Reply-To: <1470720204-4605-1-git-send-email-tj@kernel.org>
On Tue, Aug 09, 2016 at 01:23:20AM -0400, Tejun Heo wrote:
> kernfs path formatting functions always return the length of full path
> but the content of the output buffer is undefined when the length is
> longer than the provided buffer. Most cgroup path formatting
> functions return the start of the output or NULL on errors including
> overflow. These inconsistent and rather peculiar behaviors developed
> over time and make these functions unnecessarily difficult to use.
> This patchset updates the formatting functions so that they all behave
> in the style of strlcpy().
>
> Greg, these changes are used by cgroup tracepoint additions and
> shouldn't affect other users much. Would it be okay to route these
> through the cgroup tree?
>
> 0001-kernfs-add-dummy-implementation-of-kernfs_path_from_.patch
> 0002-kernfs-make-kernfs_path-behave-in-the-style-of-strlc.patch
> 0003-kernfs-remove-kernfs_path_len.patch
> 0004-cgroup-make-cgroup_path-and-friends-behave-in-the-st.patch
>
> The patches are also available in the following git branch.
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup.git review-kernfs_path-strlcpy
>
> diffstat follows. Thanks.
It's fine with me if you take these yourself:
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
thanks,
greg k-h
next prev parent reply other threads:[~2016-08-09 8:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 5:23 Tejun Heo
2016-08-09 5:23 ` [PATCH 1/4] kernfs: add dummy implementation of kernfs_path_from_node() Tejun Heo
2016-08-09 6:14 ` [PATCH v2 " Tejun Heo
2016-08-09 5:23 ` [PATCH 2/4] kernfs: make kernfs_path*() behave in the style of strlcpy() Tejun Heo
2016-08-09 15:33 ` Serge E. Hallyn
2016-08-09 19:58 ` Tejun Heo
2016-08-09 20:14 ` Serge E. Hallyn
2016-08-09 5:23 ` [PATCH 3/4] kernfs: remove kernfs_path_len() Tejun Heo
2016-08-09 5:23 ` [PATCH 4/4] cgroup: make cgroup_path() and friends behave in the style of strlcpy() Tejun Heo
2016-08-09 6:14 ` [PATCH v2 " Tejun Heo
2016-08-09 8:18 ` Greg KH [this message]
2016-08-10 15:25 ` [PATCHSET] kernfs, cgroup: make kernfs_path*() and cgroup_path*() behave in strlcpy() style Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160809081819.GB10279@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=serge.hallyn@ubuntu.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®