From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752320AbcHIIG3 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Aug 2016 04:06:29 -0400
Received: from down.free-electrons.com ([37.187.137.238]:37779 "EHLO
	mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org
	with ESMTP id S1751522AbcHIIGZ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Aug 2016 04:06:25 -0400
Date: Tue, 9 Aug 2016 10:06:21 +0200
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        dri-devel@lists.freedesktop.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/cirrus: Fix NULL pointer dereference when
 registering the fbdev
Message-ID: <20160809100621.77a3b71a@bbrezillon>
In-Reply-To: <87a8gmliky.fsf@x220.int.ebiederm.org>
References: <127976560.342868.1470693556296.JavaMail.zimbra@redhat.com>
	<1470701778-20839-1-git-send-email-boris.brezillon@free-electrons.com>
	<87a8gmliky.fsf@x220.int.ebiederm.org>
Organization: Free Electrons
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 08 Aug 2016 22:36:13 -0500
ebiederm@xmission.com (Eric W. Biederman) wrote:

> Boris Brezillon <boris.brezillon@free-electrons.com> writes:
> 
> > cirrus_modeset_init() is initializing/registering the emulated fbdev
> > and, since commit c61b93fe51b1 ("drm/atomic: Fix remaining places where
> > !funcs->best_encoder is valid"), DRM internals can access/test some of
> > the fields in mode_config->funcs as part of the fbdev registration
> > process.
> > Make sure dev->mode_config.funcs is properly set to avoid dereferencing
> > a NULL pointer.  
> 
> That fixes the issues I am seeing.
> 
> Tested-by: "Eric W. Biederman" <ebiederm@xmission.com>
> 
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > Fixes: c61b93fe51b1 ("drm/atomic: Fix remaining places where !funcs->best_encoder is valid")
> > ---
> > Hi Dave,
> >
> > As discussed on IRC, I'm sending this patch in a proper format. That's
> > probably better to wait for Eric's feeback before applying it though.  
> 
> It is weird I didn't see either of your email messages directly only
> through lkml.  Weird.

Probably because of that

"
<ebiederm@xmission.com>: host mx.xmission.com[166.70.12.20] said:
    550-XM-RJCT22: [37.187.137.238] is prohibited from connecting to
XMission mail 550-servers due to high spam volume. See the following
for more information: 550
    http://postmaster.xmission.com/senders/rbls.php?check_rbl=Submit&address=37.187.137.238
    (in reply to RCPT TO command)
"

I filled a form to add this IP to the xmission whitelist, let's see if
you receive my answer :).