From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752234AbcHILB6 (ORCPT ); Tue, 9 Aug 2016 07:01:58 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:59681 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750873AbcHILB4 (ORCPT ); Tue, 9 Aug 2016 07:01:56 -0400 Date: Tue, 9 Aug 2016 19:01:45 +0800 From: Herbert Xu To: yanjiang.jin@windriver.com Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, jinyanjiang@gmail.com Subject: Re: [PATCH] crypto/testmgr.c: fix !x==y confusion Message-ID: <20160809110145.GD7099@gondor.apana.org.au> References: <1469781129-24304-1-git-send-email-yanjiang.jin@windriver.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1469781129-24304-1-git-send-email-yanjiang.jin@windriver.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 29, 2016 at 04:32:09PM +0800, yanjiang.jin@windriver.com wrote: > From: Yanjiang Jin > > "if (!ret == template[i].fail)" is confusing to compilers (gcc5): > > crypto/testmgr.c: In function '__test_aead': > crypto/testmgr.c:531:12: warning: logical not is only applied to the > left hand side of comparison [-Wlogical-not-parentheses] > if (!ret == template[i].fail) { > ^ > > Let there be 'if (template[i].fail == !ret) '. > > Signed-off-by: Yanjiang Jin Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt