From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932473AbcHIMxT (ORCPT ); Tue, 9 Aug 2016 08:53:19 -0400 Received: from merlin.infradead.org ([205.233.59.134]:58582 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932382AbcHIMxQ (ORCPT ); Tue, 9 Aug 2016 08:53:16 -0400 Date: Tue, 9 Aug 2016 14:53:14 +0200 From: Peter Zijlstra To: Ming Lei Cc: linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [PATCH] lockdep: fix warning in case of no_validate lock Message-ID: <20160809125314.GI30192@twins.programming.kicks-ass.net> References: <1468379196-21096-1-git-send-email-tom.leiming@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468379196-21096-1-git-send-email-tom.leiming@gmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 13, 2016 at 11:06:36AM +0800, Ming Lei wrote: > Now there are several locks which are marked as > no_validate, so name of the lock class can be > different with the no_validate lock. Hurgh, how did that happen? See checkpatch saying: scripts/checkpatch.pl: "lockdep_no_validate class is reserved for device->mutex.\n" . $herecurr); > This patch avoids this warning for this case, and > fix the following warning: I'm not sure we want that.. given we should strive for less no_validate usage, not more.