From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933016AbcHIOAC (ORCPT ); Tue, 9 Aug 2016 10:00:02 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:60150 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932914AbcHIN7P (ORCPT ); Tue, 9 Aug 2016 09:59:15 -0400 Date: Tue, 9 Aug 2016 15:59:28 +0200 From: Greg Kroah-Hartman To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Tony Prisk , Alan Stern , "moderated list:ARM/VT8500 ARM ARCHITECTURE" , "open list:USB EHCI DRIVER" , open list Subject: Re: [PATCH V2] usb: ehci-platform: use helper variables in probe function Message-ID: <20160809135928.GB3021@kroah.com> References: <1468398548-5050-1-git-send-email-zajec5@gmail.com> <1468559156-17270-1-git-send-email-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1468559156-17270-1-git-send-email-zajec5@gmail.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 15, 2016 at 07:05:56AM +0200, Rafał Miłecki wrote: > Probing function was using &dev->dev and dev->dev.of_node over 20 times > so I believe it made sense to use helper variables for both of them. > To avoid some uncommon variable name for struct device I first replaced > existing dev variable with pdev. > > Signed-off-by: Rafał Miłecki > Acked-by: Alan Stern > --- > V2: Use 2 extra tabs after line break to match one of already used > coding styles. Same comment here, unnecessary churn, sorry. greg k-h