From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932885AbcHIX3W (ORCPT ); Tue, 9 Aug 2016 19:29:22 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42151 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932540AbcHIX3V (ORCPT ); Tue, 9 Aug 2016 19:29:21 -0400 Date: Tue, 9 Aug 2016 16:29:19 -0700 From: Andrew Morton To: zhongjiang Cc: , Subject: Re: [PATCH] mm: optimize find_zone_movable_pfns_for_nodes to avoid unnecessary loop. Message-Id: <20160809162919.266e58ca0c33896dcf417a02@linux-foundation.org> In-Reply-To: <1470405847-53322-1-git-send-email-zhongjiang@huawei.com> References: <1470405847-53322-1-git-send-email-zhongjiang@huawei.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 5 Aug 2016 22:04:07 +0800 zhongjiang wrote: > when required_kernelcore decrease to zero, we should exit the loop in time. > because It will waste time to scan the remainder node. The patch is rather ugly and it only affects __init code, so the only benefit will be to boot time. Do we have any timing measurements which would justify changing this code?