From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932506AbcHIQaQ (ORCPT ); Tue, 9 Aug 2016 12:30:16 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33587 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932337AbcHIQaP (ORCPT ); Tue, 9 Aug 2016 12:30:15 -0400 Date: Tue, 9 Aug 2016 19:30:11 +0300 From: "Kirill A. Shutemov" To: Arnd Bergmann Cc: Andrew Morton , Hugh Dickins , Al Viro , "Kirill A. Shutemov" , Vlastimil Babka , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] thp: move shmem_huge_enabled() outside of SYSFS ifdef Message-ID: <20160809163011.GB10293@node.shutemov.name> References: <20160809123638.1357593-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160809123638.1357593-1-arnd@arndb.de> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 09, 2016 at 02:36:02PM +0200, Arnd Bergmann wrote: > The newly introduced shmem_huge_enabled() function has two definitions, > but neither of them is visible if CONFIG_SYSFS is disabled, leading > to a build error: > > mm/khugepaged.o: In function `khugepaged': > khugepaged.c:(.text.khugepaged+0x3ca): undefined reference to `shmem_huge_enabled' > > This changes the #ifdef guards around the definition to match those that > are used in the header file. > > Signed-off-by: Arnd Bergmann > Fixes: e496cf3d7821 ("thp: introduce CONFIG_TRANSPARENT_HUGE_PAGECACHE") Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov