Re: [PATCH] x86/mm: minor warning message cleanup

[Borislav Petkov <bp@suse.de>]

On Tue, Aug 09, 2016 at 01:56:31PM -0400, Prarit Bhargava wrote:
> Capitalize R in RIP.
> 
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: x86@kernel.org
> Cc: Andy Lutomirski <luto@kernel.org>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Tony Luck <tony.luck@intel.com>
> ---
>  arch/x86/mm/extable.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/mm/extable.c b/arch/x86/mm/extable.c
> index 832b98f822be..bef3aa199f94 100644
> --- a/arch/x86/mm/extable.c
> +++ b/arch/x86/mm/extable.c
> @@ -62,7 +62,7 @@ EXPORT_SYMBOL(ex_handler_rdmsr_unsafe);
>  bool ex_handler_wrmsr_unsafe(const struct exception_table_entry *fixup,
>  			     struct pt_regs *regs, int trapnr)
>  {
> -	if (pr_warn_once("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at rIP: 0x%lx (%pF)\n",
> +	if (pr_warn_once("unchecked MSR access error: WRMSR to 0x%x (tried to write 0x%08x%08x) at RIP: 0x%lx (%pF)\n",

Nope:

rIP:	16-bit, 32-bit, or 64-bit instruction-pointer register. Compare RIP.
RIP:	64-bit instruction-pointer register.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--