From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbcHIUSy (ORCPT ); Tue, 9 Aug 2016 16:18:54 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:33360 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449AbcHIUSu (ORCPT ); Tue, 9 Aug 2016 16:18:50 -0400 X-Sasl-enc: bbJ+Yf1lO09BfseXz4eBO8YfO87DF1lKfy5U76ekM18h 1470773929 Date: Tue, 9 Aug 2016 17:18:46 -0300 From: Henrique de Moraes Holschuh To: Jason Cooper Cc: Herbert Xu , Keith Packard , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwrng: core - Allow for multiple simultaneous active hwrng devices Message-ID: <20160809201846.GA4684@khazad-dum.debian.net> References: <1469477255-26824-1-git-send-email-keithp@keithp.com> <20160809095058.GA6618@gondor.apana.org.au> <20160809165710.GC2013@io.lakedaemon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160809165710.GC2013@io.lakedaemon.net> X-GPG-Fingerprint1: 4096R/39CB4807 C467 A717 507B BAFE D3C1 6092 0BD9 E811 39CB 4807 User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 09 Aug 2016, Jason Cooper wrote: > Perhaps a /dev/hwrng[0-9] per rng? That would lend itself nicely to a > sysfs interface for per device quality, rate, and enabled attributes. > e.g. /sys/class/hw_random/hwrng0/{device/,quality,rate,enabled} IMHO, this is mightly annoying to use from inside a rngd-like utility in a race-free, safe way. It looks to me that ioctl() would be a much better interface for everything but the "enabled" functionality (which should be reported to the rngd-like utility as open() on the real device failing with, e.g., ENXIO, when that source is disabled). -- Henrique Holschuh