From: kbuild test robot <lkp@intel.com>
To: robert.foss@collabora.com
Cc: kbuild-all@01.org, mathias.nyman@intel.com,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Julius Werner <jwerner@chromium.org>,
Andrew Bresticker <abrestic@chromium.org>,
Felipe Balbi <felipe.balbi@linux.intel.com>,
Robert Foss <robert.foss@collabora.com>
Subject: Re: [PACTH v4 1/2] usb: xhci: plat: Enable runtime PM
Date: Wed, 10 Aug 2016 00:22:23 +0800 [thread overview]
Message-ID: <201608100057.xeX4kM87%fengguang.wu@intel.com> (raw)
In-Reply-To: <1470757245-7863-2-git-send-email-robert.foss@collabora.com>
[-- Attachment #1: Type: text/plain, Size: 2484 bytes --]
Hi Robert,
[auto build test WARNING on usb/usb-testing]
[also build test WARNING on v4.8-rc1 next-20160809]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/robert-foss-collabora-com/usb-xhci-plat-Enable-PM-async-resume-suspend/20160809-234302
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
config: i386-randconfig-s0-201632 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
# save the attached .config to linux build tree
make ARCH=i386
All warnings (new ones prefixed by >>):
drivers/usb/host/xhci-plat.c: In function 'xhci_plat_suspend':
>> drivers/usb/host/xhci-plat.c:303:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (ret < 0)
^~
drivers/usb/host/xhci-plat.c:305:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
return ret;
^~~~~~
drivers/usb/host/xhci-plat.c: In function 'xhci_plat_resume':
drivers/usb/host/xhci-plat.c:327:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
if (ret < 0)
^~
drivers/usb/host/xhci-plat.c:329:3: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the 'if'
return ret;
^~~~~~
vim +/if +303 drivers/usb/host/xhci-plat.c
287
288 if (!IS_ERR(clk))
289 clk_disable_unprepare(clk);
290 usb_put_hcd(hcd);
291
292 return 0;
293 }
294
295 #ifdef CONFIG_PM_SLEEP
296 static int xhci_plat_suspend(struct device *dev)
297 {
298 struct usb_hcd *hcd = dev_get_drvdata(dev);
299 struct xhci_hcd *xhci = hcd_to_xhci(hcd);
300 int ret;
301
302 ret = pm_runtime_get_sync(dev);
> 303 if (ret < 0)
304 atomic_dec(&dev->power.usage_count);
305 return ret;
306 /*
307 * xhci_suspend() needs `do_wakeup` to know whether host is allowed
308 * to do wakeup during suspend. Since xhci_plat_suspend is currently
309 * only designed for system suspend, device_may_wakeup() is enough
310 * to dertermine whether host is allowed to do wakeup. Need to
311 * reconsider this when xhci_plat_suspend enlarges its scope, e.g.,
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 34089 bytes --]
next prev parent reply other threads:[~2016-08-09 16:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-09 15:40 [PACTH v4 0/2] usb: xhci: plat: Enable PM, async resume/suspend robert.foss
2016-08-09 15:40 ` [PACTH v4 1/2] usb: xhci: plat: Enable runtime PM robert.foss
2016-08-09 16:22 ` kbuild test robot [this message]
2016-08-09 15:40 ` [PACTH v4 2/2] usb: xhci: plat: Enable async suspend/resume robert.foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201608100057.xeX4kM87%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=abrestic@chromium.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=robert.foss@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®