From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752544AbcHKCI6 (ORCPT ); Wed, 10 Aug 2016 22:08:58 -0400 Received: from marchena.puc.rediris.es ([130.206.18.4]:47357 "EHLO marchena.puc.rediris.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750857AbcHKCI4 (ORCPT ); Wed, 10 Aug 2016 22:08:56 -0400 X-Greylist: delayed 18403 seconds by postgrey-1.27 at vger.kernel.org; Wed, 10 Aug 2016 22:08:56 EDT X-Envelope-From: paubert@iram.es Date: Wed, 10 Aug 2016 10:56:05 +0200 From: Gabriel Paubert To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Scott Wood , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/32: Remove one insn in __bswapdi2 Message-ID: <20160810085605.GB2117@visitor2.iram.es> References: <20160805112803.36D3B1A2399@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160805112803.36D3B1A2399@localhost.localdomain> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spamina-Bogosity: Unsure X-Spamina-Spam-Score: -1.0 (-) X-Spamina-Spam-Report: Content analysis details: (-1.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -0.0 BAYES_40 BODY: Bayes spam probability is 20 to 40% [score: 0.2190] 0.0 URIBL_BLOCKED ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [URIs: c-s.fr] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 05, 2016 at 01:28:02PM +0200, Christophe Leroy wrote: > Signed-off-by: Christophe Leroy > --- > arch/powerpc/kernel/misc_32.S | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/powerpc/kernel/misc_32.S b/arch/powerpc/kernel/misc_32.S > index e025230..e18055c 100644 > --- a/arch/powerpc/kernel/misc_32.S > +++ b/arch/powerpc/kernel/misc_32.S > @@ -578,9 +578,8 @@ _GLOBAL(__bswapdi2) > rlwimi r9,r4,24,0,7 > rlwimi r10,r3,24,0,7 > rlwimi r9,r4,24,16,23 > - rlwimi r10,r3,24,16,23 > + rlwimi r4,r3,24,16,23 > mr r3,r9 > - mr r4,r10 > blr > Hmmm, are you sure that it works? rlwimi is a bit special since the first operand is both an input and an output of the instruction. In other words, did you test the code? Gabriel