From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938851AbcHJTkF (ORCPT ); Wed, 10 Aug 2016 15:40:05 -0400 Received: from kirsty.vergenet.net ([202.4.237.240]:59198 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938816AbcHJSto (ORCPT ); Wed, 10 Aug 2016 14:49:44 -0400 Date: Wed, 10 Aug 2016 11:19:23 +0200 From: Simon Horman To: Philippe Reynes Cc: sergei.shtylyov@cogentembedded.com, davem@davemloft.net, geert+renesas@glider.be, andrew@lunn.ch, netdev@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH 1/2] net: ethernet: renesas: sh_eth: use phydev from struct net_device Message-ID: <20160810091923.GE6276@verge.net.au> References: <1470780289-27496-1-git-send-email-tremyfr@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470780289-27496-1-git-send-email-tremyfr@gmail.com> Organisation: Horms Solutions BV User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [CC linux-sh as some of those boards use this driver] On Wed, Aug 10, 2016 at 12:04:48AM +0200, Philippe Reynes wrote: > The private structure contain a pointer to phydev, but the structure > net_device already contain such pointer. So we can remove the pointer > phy_dev in the private structure, and update the driver to use the > one contained in struct net_device. > > Signed-off-by: Philippe Reynes I have looked over this and it seems good to me. I have also tested it on the r8a7790/Lager board and it appears to work. Tested-by: Simon Horman