From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938663AbcHJSsI (ORCPT ); Wed, 10 Aug 2016 14:48:08 -0400 Received: from mail.osadl.at ([92.243.35.153]:38616 "EHLO mail.osadl.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936640AbcHJSsF (ORCPT ); Wed, 10 Aug 2016 14:48:05 -0400 Date: Wed, 10 Aug 2016 10:30:19 +0000 From: Nicholas Mc Guire To: Tomi Valkeinen Cc: Nicholas Mc Guire , Jean-Christophe Plagniol-Villard , Rob Clark , Dave Airlie , Peter Ujfalusi , Luis de Bethencourt , linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] omapfb/dss: wait_for_completion_interruptible_timeout expects long Message-ID: <20160810103019.GA3842@osadl.at> References: <1469466767-23352-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2016 at 01:21:46PM +0300, Tomi Valkeinen wrote: > On 25/07/16 20:12, Nicholas Mc Guire wrote: > > wait_for_completion_timeout_interruptible returns long not unsigned long. > > an appropriately typed variable is introduced and assignments fixed up. > > > > Fixes: f76ee892a99e ("omapfb: copy omapdss & displays for omapfb") > > > > Signed-off-by: Nicholas Mc Guire > > --- > > > > API non-compliance was located by coccinelle > > > > This is mostly cosmetic since the returned value is only compared > > at present, however if remaining time (completion occurred) where ever > > used, then a signal received would be interpreted as a large remaining > > jiffies left, which would be wrong. > > > > Compile tested with: omap2plus_defconfig (implies CONFIG_FB_OMAP2_DSS) > > > > Patch is against 4.7.0-rc7 (localversion-next -next-20160724) > > > > drivers/video/fbdev/omap2/omapfb/dss/dispc-compat.c | 7 ++++--- > > 1 file changed, 4 insertions(+), 3 deletions(-) > > Thanks, queued for v4.9. I dropped the "Fixes: " line, as that commit > only does a copy of the files, so the commit didn't really introduce the > bug. > sorry for the wrong fixes tag - did not notice that - and thanks for fixing this. thx! hofrat