From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964992AbcHJTB2 (ORCPT ); Wed, 10 Aug 2016 15:01:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48382 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935144AbcHJTBX (ORCPT ); Wed, 10 Aug 2016 15:01:23 -0400 Date: Wed, 10 Aug 2016 22:13:40 +0800 From: Baoquan He To: Ingo Molnar Cc: rjw@rjwysocki.net, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [Patch v3 2/2] x86/acpi: Remove the repeated lapic address override entry parsing Message-ID: <20160810141340.GA5477@x1.redhat.com> References: <1469877001-18393-1-git-send-email-bhe@redhat.com> <1469877001-18393-2-git-send-email-bhe@redhat.com> <20160810140257.GB22965@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160810140257.GB22965@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 10 Aug 2016 14:13:51 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/10/16 at 04:02pm, Ingo Molnar wrote: > > * Baoquan He wrote: > > > ACPI MADT has a 32-bit field providing lapic address at which > > each processor can access its lapic information. MADT also contains > > an optional entry to provide a 64-bit address to override the 32-bit > > one. However the current code does the lapic address override entry > > parsing twice. One is in early_acpi_boot_init() because AMD NUMA need > > get boot_cpu_id earlier. The other is in acpi_boot_init() which parses > > all MADT entries. > > > > So in this patch remove the repeated code in the 2nd part. Meanwhile > > print lapic override entry information like other MADT entry, this > > will be added to boot log. > > it is not at all clear to me from this changelog whether the change is supposed to > change anything. If not then please spell it out explicitly: > > "This patch is not supposed to change any behavior." I don't know if adding new information to boot log can be seen as behavior change. If lapic override entry exist, the code change will add one line of message to boot log: LAPIC_ADDR_OVR (address[0xXXXXXXXX]) If this is not behavior change, I will add the sentence you suggested. Thanks Baoquan