mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: robert.foss@collabora.com
Cc: adurbin@chromium.org, penguin-kernel@I-love.SAKURA.ne.jp,
	linux-kernel@vger.kernel.org
Subject: Re: [PACTH v1] kernel/hung_task.c: Dump all UNINTERUPTIBLE tasks
Date: Wed, 10 Aug 2016 15:43:45 -0700	[thread overview]
Message-ID: <20160810154345.f0c34d0936b0835b541405b0@linux-foundation.org> (raw)
In-Reply-To: <1470151391-16420-1-git-send-email-robert.foss@collabora.com>

On Tue,  2 Aug 2016 11:23:11 -0400 robert.foss@collabora.com wrote:

> From: Aaron Durbin <adurbin@chromium.org>
> 
> When the panic path is taken for khungtaskd dump all
> tasks with the UNINTERUPTIBLE state. That way, any
> inter-dependent tasks that caused one another to hang
> will be saved in the crash output.
> 
> ...
>
> --- a/kernel/hung_task.c
> +++ b/kernel/hung_task.c
> @@ -122,6 +122,8 @@ static void check_hung_task(struct task_struct *t, unsigned long timeout)
>  	touch_nmi_watchdog();
>  
>  	if (sysctl_hung_task_panic) {
> +		/* Dump all tasks. */
> +		show_state_filter(TASK_UNINTERRUPTIBLE);
>  		trigger_all_cpu_backtrace();
>  		panic("hung_task: blocked tasks");
>  	}

Well, it's going to produce more gunk for the operator to read through
and understand.

I'd like to hear a little more about the value of this change: what
particular problem prompted it, etc.

  parent reply	other threads:[~2016-08-10 22:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-02 15:23 robert.foss
2016-08-04 13:22 ` Tetsuo Handa
2016-08-04 15:29   ` Robert Foss
2016-08-10 22:43 ` Andrew Morton [this message]
2016-08-11 16:35   ` Robert Foss
2016-08-29 19:04     ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160810154345.f0c34d0936b0835b541405b0@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=adurbin@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@I-love.SAKURA.ne.jp \
    --cc=robert.foss@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®