From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753478AbcHJTkC (ORCPT ); Wed, 10 Aug 2016 15:40:02 -0400 Received: from mga03.intel.com ([134.134.136.65]:38315 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752600AbcHJSty (ORCPT ); Wed, 10 Aug 2016 14:49:54 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,500,1464678000"; d="scan'208";a="746913971" Date: Wed, 10 Aug 2016 19:14:19 +0300 From: "Kirill A. Shutemov" To: Steve Capper Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, shijie.huang@arm.com, will.deacon@arm.com, catalin.marinas@arm.com, Andrew Morton Subject: Re: [PATCH v2] rmap: Fix compound check logic in page_remove_file_rmap Message-ID: <20160810161419.GB67522@black.fi.intel.com> References: <1470838217-5889-1-git-send-email-steve.capper@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1470838217-5889-1-git-send-email-steve.capper@arm.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 10, 2016 at 03:10:17PM +0100, Steve Capper wrote: > In page_remove_file_rmap(.) we have the following check: > VM_BUG_ON_PAGE(compound && !PageTransHuge(page), page); > > This is meant to check for either HugeTLB pages or THP when a compound > page is passed in. > > Unfortunately, if one disables CONFIG_TRANSPARENT_HUGEPAGE, then > PageTransHuge(.) will always return false, provoking BUGs when one runs > the libhugetlbfs test suite. > > This patch replaces PageTransHuge(), with PageHead() which will work for > both HugeTLB and THP. > > Fixes: dd78fedde4b9 ("rmap: support file thp") > Cc: Kirill A. Shutemov > Cc: Andrew Morton > Signed-off-by: Steve Capper Acked-by: Kirill A. Shutemov -- Kirill A. Shutemov