From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932507AbcHJV5A (ORCPT ); Wed, 10 Aug 2016 17:57:00 -0400 Received: from mout.kundenserver.de ([212.227.126.135]:50332 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932380AbcHJV47 (ORCPT ); Wed, 10 Aug 2016 17:56:59 -0400 From: Arnd Bergmann To: David Airlie Cc: Arnd Bergmann , Matthias Brugger , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: [PATCH 3/9] drm/mediatek: add COMMON_CLK dependency Date: Wed, 10 Aug 2016 23:54:09 +0200 Message-Id: <20160810215424.1926658-4-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160810215424.1926658-1-arnd@arndb.de> References: <20160810215424.1926658-1-arnd@arndb.de> X-Provags-ID: V03:K0:CQEVIpbZ4Rxj/MRAYZUmf1QWNiiP9KIhKIxnAgwJxugXbJEI8dj D7hJkHrQlglrExyaQyQu323EGpDI+Bx8J3Od28iOmREwDvZr3w+cmFoZw+4IaGrfmdJeQVB m8sU6B4DYz/zTke0iYk5P5boVeuBGt2Zk7hJrBr38W+eqXRNuK5IW6WXQc42ZyDcGp8Esy3 4NPQXBvhIRYbfH3H0gcJQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:xnLJZLZaoq4=:+XMkP96Yc6CDvGr/CxCaqI HghQp6vadSqeC50FIzWW98WQ90dk3AKTzUxoUuCGk3B6ypBpqsFe01SlRypUhdG2mqs1BTUVH KsVgkkGhkboMZDcOJ/jSoRCoXgf6CHYmV+mc6eddTZN1YUtL0/mSnJpvDdAKVpLjY8D3YIMzx gvh2O8MPoWCLgSK3mrBRW64EvJ/9QDYcNBkOtdajRt5H5VFeaYoiwumRi7ShM+h49jdYmQ2Iz 0t+dvAAlC0qa4/qjPAb44SHKoYsMKDAV4d1QyjygLxveGnv73yNKxFbdMzPGdBVmO8/Bv29Ln iae9UgNK2oFDrcc7RMUbTOeCkW8OxQPwH211E+3CxVT6l4/qUgkiLmd4m1dtttz5OZxzG7L8E wWwwlBfPxNq+m10OUMa+HfslhTNViT4LvMOk0pvFJF76uVQnBuCOXxGeYYH+2xT7j1CaxUvHT x21U2nvdId8YgPjh7aU0BUXOkpnZEImbB5TNzvcODAsqSz4aoHbqxpKgpuTHs2rLDEIl81+wx r09MJ3iHQ8sqkVSYLRTQtoObpc7C7QF9Ioga95QI9vOvfqEG1Zz78zAN/ffalwfGtGsbrJB8f REHPy9F3/iH6B4RiAmJRcPTnPTPcgtIQ4NUCX9XuR3hgj+DXp19jZpDL4eEYnpbMLuY8HJ+x2 8ahVEsjNjIq1csN5nGzCdauUUoXgMwTFXqvMgmOdVNddLZuXgxV6Vqa8c3d3ZR1/jbyA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On kernel builds without COMMON_CLK, the newly added mediatek drm driver fails to build: drivers/gpu/drm/mediatek/mtk_mipi_tx.c:130:16: error: field 'pll_hw' has incomplete type struct clk_hw pll_hw; ^~~~~~ In file included from ../include/linux/clk.h:16:0, from ../drivers/gpu/drm/mediatek/mtk_mipi_tx.c:14: drivers/gpu/drm/mediatek/mtk_mipi_tx.c: In function 'mtk_mipi_tx_from_clk_hw': include/linux/kernel.h:831:48: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] const typeof( ((type *)0)->member ) *__mptr = (ptr); \ ^ /drivers/gpu/drm/mediatek/mtk_mipi_tx.c:136:9: note: in expansion of macro 'container_of' return container_of(hw, struct mtk_mipi_tx, pll_hw); ^~~~~~~~~~~~ drivers/gpu/drm/mediatek/mtk_mipi_tx.c: At top level: drivers/gpu/drm/mediatek/mtk_mipi_tx.c:302:21: error: variable 'mtk_mipi_tx_pll_ops' has initializer but incomplete type static const struct clk_ops mtk_mipi_tx_pll_ops = { This adds the required Kconfig dependency. Signed-off-by: Arnd Bergmann Acked-by: Philipp Zabel Link: https://patchwork.kernel.org/patch/9069061/ --- I originally sent this on May 11 2016 after the driver was added with this bug, but my fix never made it in. --- drivers/gpu/drm/mediatek/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig index 23ac8041c562..5c2163737691 100644 --- a/drivers/gpu/drm/mediatek/Kconfig +++ b/drivers/gpu/drm/mediatek/Kconfig @@ -2,6 +2,7 @@ config DRM_MEDIATEK tristate "DRM Support for Mediatek SoCs" depends on DRM depends on ARCH_MEDIATEK || (ARM && COMPILE_TEST) + depends on COMMON_CLK select DRM_GEM_CMA_HELPER select DRM_KMS_HELPER select DRM_MIPI_DSI -- 2.9.0