From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932796AbcHKQ4Z (ORCPT ); Thu, 11 Aug 2016 12:56:25 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:46974 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932489AbcHKQ4W (ORCPT ); Thu, 11 Aug 2016 12:56:22 -0400 Date: Thu, 11 Aug 2016 09:56:20 -0700 (PDT) Message-Id: <20160811.095620.2209757084053700354.davem@davemloft.net> To: jasowang@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com, mst@redhat.com Subject: Re: [PATCH net] macvtap: fix use after free for skb_array during release From: David Miller In-Reply-To: <1470910556-11872-1-git-send-email-jasowang@redhat.com> References: <1470910556-11872-1-git-send-email-jasowang@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 11 Aug 2016 09:56:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Thu, 11 Aug 2016 18:15:56 +0800 > We've clean skb_array in macvtap_put_queue() but still try to pop from > it during macvtap_sock_destruct(). Fix this use after free by moving > the skb array cleanup to macvtap_sock_destruct() instead. > > Fixes: 362899b8725b ("macvtap: switch to use skb array") > Reported-by: Cornelia Huck > Tested-by: Cornelia Huck > Signed-off-by: Jason Wang Applied, thanks for fixing this so quickly Jason.