From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932487AbcHKHJB (ORCPT ); Thu, 11 Aug 2016 03:09:01 -0400 Received: from mx2.suse.de ([195.135.220.15]:54411 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932243AbcHKHI7 (ORCPT ); Thu, 11 Aug 2016 03:08:59 -0400 Date: Thu, 11 Aug 2016 09:08:35 +0200 From: Borislav Petkov To: Maninder Singh Cc: ard.biesheuvel@linaro.org, catalin.marinas@arm.com, bp@suse.de, deller@gmx.de, will.deacon@arm.com, tony.luck@intel.com, linux-kernel@vger.kernel.org, ajeet.y@samsung.com, pankaj.m@samsung.com, Vaneet Narang Subject: Re: [PATCH 2/2] scripts/sortextable: set the variable mmap_failure Message-ID: <20160811070835.GA19713@nazgul.tnic> References: <1470889375-15079-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1470889375-15079-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2016 at 09:52:55AM +0530, Maninder Singh wrote: > Currently mmap_failed variable is 1 for every case, so make it 0 > if mmap is success. > > Signed-off-by: Maninder Singh > Signed-off-by: Vaneet Narang See section 11) of Documentation/SubmittingPatches on how the sign-off chain should be done. It is not clear from your current submission what Vaneet's role is in the creation of this patch is. Ditto for your other patch. > --- > scripts/sortextable.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/sortextable.c b/scripts/sortextable.c > index 30b4e7c..0b6a31b 100644 > --- a/scripts/sortextable.c > +++ b/scripts/sortextable.c > @@ -106,6 +106,7 @@ static void *mmap_file(char const *fname) > } > addr = mmap(0, sb.st_size, PROT_READ|PROT_WRITE, MAP_SHARED, > fd_map, 0); > + mmap_failed = 0; This mmap_failed thing looks like a disaster. It is only needed so that we know to do munmap() but munmap() works even if the range is not mapped so you probably could go and remove that mmap_failed thing altogether. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --