From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752842AbcHKONi (ORCPT <rfc822;w@1wt.eu>);
	Thu, 11 Aug 2016 10:13:38 -0400
Received: from verein.lst.de ([213.95.11.211]:41671 "EHLO newverein.lst.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750786AbcHKONh (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 11 Aug 2016 10:13:37 -0400
Date: Thu, 11 Aug 2016 16:13:34 +0200
From: Christoph Hellwig <hch@lst.de>
To: Shaun Tancheff <shaun@tancheff.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
        Christoph Hellwig <hch@lst.de>, Tejun Heo <tj@kernel.org>,
        Josh Bingaman <josh.bingaman@seagate.com>,
        Shaun Tancheff <shaun.tancheff@seagate.com>
Subject: Re: [PATCH v5 1/2] Use kmap_atomic when rewriting attached page
Message-ID: <20160811141334.GA16956@lst.de>
References: <1470790829-3793-1-git-send-email-shaun@tancheff.com> <1470790829-3793-2-git-send-email-shaun@tancheff.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1470790829-3793-2-git-send-email-shaun@tancheff.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> +static unsigned int ata_format_dsm_trim_descr(struct scatterlist *sg, u32 num,
> +					      u64 sector, u32 count)
> +{
> +	void *ptr = kmap_atomic(sg_page(sg));


Please use sg_copy_from_buffer to be safe against all corner cases.