From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752793AbcHKO6w (ORCPT ); Thu, 11 Aug 2016 10:58:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42832 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751539AbcHKO6s (ORCPT ); Thu, 11 Aug 2016 10:58:48 -0400 Date: Thu, 11 Aug 2016 16:58:43 +0200 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Jiri Olsa , lkml , David Ahern , Ingo Molnar , Namhyung Kim , Peter Zijlstra , Michael Petlan Subject: Re: [PATCH] perf tools mem: Fix -t store option for record command Message-ID: <20160811145843.GB28317@krava> References: <1470905457-18311-1-git-send-email-jolsa@kernel.org> <20160811115138.GB27651@kernel.org> <20160811120032.GA18451@krava> <20160811144646.GC27651@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160811144646.GC27651@kernel.org> User-Agent: Mutt/1.6.2 (2016-07-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 11 Aug 2016 14:58:47 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 11, 2016 at 11:46:46AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 11, 2016 at 02:00:32PM +0200, Jiri Olsa escreveu: > > On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu: > > > > Michael reported 'perf mem -t store record' being broken. > > > > The reason is latest rework of this area: > > > > commit acbe613e0c03 ("perf tools: Add monitored events array") > > > > > > > > We don't mark perf_mem_events store record when -t store > > > > option is specified. > > > > > > > > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array") > > > ^^^^^^ > > > I'll remove this extraneous bit > > > > well, checkpatch script complained about that when > > I did not put it there.. but I don't mind ;-) > > Huh? ah that was the other line with the commit number, the one with Fixes: tag is ok.. nevermind, sry for noise ;-) jirka --- [jolsa@krava linux-perf]$ ./scripts/checkpatch.pl 0001-perf-tools-mem-Fix-t-store-option-for-record-command.patch ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("")' - ie: 'commit acbe613e0c03 ("perf tools: Add monitored events array")' #8: acbe613e0c03 ("perf tools: Add monitored events array") total: 1 errors, 0 warnings, 9 lines checked