From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752422AbcHKT3F (ORCPT ); Thu, 11 Aug 2016 15:29:05 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:35020 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932105AbcHKT3B (ORCPT ); Thu, 11 Aug 2016 15:29:01 -0400 Date: Thu, 11 Aug 2016 22:28:24 +0300 From: Sakari Ailus To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab , Laurent Pinchart , Hans Verkuil , linux-media@vger.kernel.org Subject: Re: [PATCH 2/8] [media] v4l2-async: call registered_async after subdev registration Message-ID: <20160811192824.GT3182@valkosipuli.retiisi.org.uk> References: <1454699398-8581-1-git-send-email-javier@osg.samsung.com> <1454699398-8581-3-git-send-email-javier@osg.samsung.com> <20160811111042.GQ3182@valkosipuli.retiisi.org.uk> <20160811111817.GS3182@valkosipuli.retiisi.org.uk> <7c4b87b3-38e9-6b4e-730e-d65b0d72dd1d@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7c4b87b3-38e9-6b4e-730e-d65b0d72dd1d@osg.samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Javier, On Thu, Aug 11, 2016 at 12:14:01PM -0400, Javier Martinez Canillas wrote: > Hello Sakari, > > Thanks a lot for your feedback. > > On 08/11/2016 07:18 AM, Sakari Ailus wrote: > > On Thu, Aug 11, 2016 at 02:10:43PM +0300, Sakari Ailus wrote: > > [snip] > > >>> > >>> + ret = v4l2_subdev_call(sd, core, registered_async); > >>> + if (ret < 0) { > >>> + if (notifier->unbind) > >>> + notifier->unbind(notifier, sd, asd); > >>> + return ret; > >>> + } > >>> + > >>> if (list_empty(¬ifier->waiting) && notifier->complete) > >>> return notifier->complete(notifier); > >> > >> I noticed this just now but what do you need this and the next patch for? > >> > >> We already have a callback for the same purpose: it's > >> v4l2_subdev_ops.internal_ops.registered(). And there's similar > >> unregistered() callback as well. > >> > > Oh, I missed we already had those calls. When adding the connector > support, I looked at struct v4l2_subdev_core_ops and didn't find a > callback that fit but didn't notice we already had a .registered() > in struct struct v4l2_subdev_internal_ops. Sorry about that... No worries. I hadn't time to review the patches either. > >> Could you use these callbacks instead? > > Yes, those can be used indeed. I'll post patches using that instead > and removing the .registered_async callback since as you said isn't > really needed. I'd appreciate that! Please cc me when you do so. -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk