From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752673AbcHMDkv (ORCPT ); Fri, 12 Aug 2016 23:40:51 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:56969 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234AbcHMDkt (ORCPT ); Fri, 12 Aug 2016 23:40:49 -0400 Date: Fri, 12 Aug 2016 20:40:48 -0700 (PDT) Message-Id: <20160812.204048.1773150628029363073.davem@davemloft.net> To: vkuznets@redhat.com Cc: netdev@vger.kernel.org, devel@linuxdriverproject.org, linux-kernel@vger.kernel.org, haiyangz@microsoft.com, kys@microsoft.com Subject: Re: [PATCH net 2/4] hv_netvsc: reset vf_inject on VF removal From: David Miller In-Reply-To: <1470913137-29167-3-git-send-email-vkuznets@redhat.com> References: <1470913137-29167-1-git-send-email-vkuznets@redhat.com> <1470913137-29167-3-git-send-email-vkuznets@redhat.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 12 Aug 2016 20:40:49 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vitaly Kuznetsov Date: Thu, 11 Aug 2016 12:58:55 +0200 > We reset vf_inject on VF going down (netvsc_vf_down()) but we don't on > VF removal (netvsc_unregister_vf()) so vf_inject stays 'true' while > vf_netdev is already NULL and we're trying to inject packets into NULL > net device in netvsc_recv_callback() causing kernel to crash. > > Signed-off-by: Vitaly Kuznetsov You can't create a blocking operation problem knowingly in this patch just because you fix it in patch #4. You must order your patches such that the driver does not regress at any intermediate stage of your patch series.