From: Borislav Petkov <bp@suse.de>
To: Thomas Garnier <thgarnie@google.com>,
"Rafael J . Wysocki" <rjw@rjwysocki.net>
Cc: Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
keescook@chromium.org, kernel-hardening@lists.openwall.com,
jikos@kernel.org, yinghai@kernel.org
Subject: Re: [PATCH v1] x86/power/64: Restore processor state before using per-cpu variables
Date: Fri, 12 Aug 2016 07:49:13 +0200 [thread overview]
Message-ID: <20160812054913.GA24303@nazgul.tnic> (raw)
In-Reply-To: <1470952169-39061-1-git-send-email-thgarnie@google.com>
On Thu, Aug 11, 2016 at 02:49:29PM -0700, Thomas Garnier wrote:
> Restore the processor state before calling any other function to ensure
> per-cpu variables can be used with KASLR memory randomization.
>
> Tracing functions use per-cpu variables (gs based) and one was called
> just before restoring the processor state fully. It resulted in a double
> fault when both the tracing & the exception handler functions tried to
> use a per-cpu variable.
>
> Signed-off-by: Thomas Garnier <thgarnie@google.com>
> ---
> Based on next-20160808
Ok, I believe before I test this, I need to apply another patch from
Rafael. I think it is the "Always create temporary identity mapping
correctly" thing.
Yes, no?
Rafael, can you please apply everything on a test branch for us to run?
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--
next prev parent reply other threads:[~2016-08-12 5:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 21:49 Thomas Garnier
2016-08-12 5:49 ` Borislav Petkov [this message]
2016-08-12 11:14 ` Rafael J. Wysocki
2016-08-12 16:03 ` Thomas Garnier
2016-08-12 17:45 ` Borislav Petkov
2016-08-12 6:01 ` Jiri Kosina
2016-08-12 9:23 ` Jiri Kosina
2016-08-12 16:03 ` Thomas Garnier
2016-08-12 6:29 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160812054913.GA24303@nazgul.tnic \
--to=bp@suse.de \
--cc=jikos@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=thgarnie@google.com \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®