mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Wanpeng Li <kernellwp@gmail.com>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org,
	kvm@vger.kernel.org, Wanpeng Li <wanpeng.li@hotmail.com>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@arm.com>, Luca Abeni <luca.abeni@unitn.it>,
	Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH v2] sched/deadline: Fix the intention to re-evalute tick dependency for offline cpu
Date: Fri, 12 Aug 2016 16:57:26 +0800	[thread overview]
Message-ID: <201608121637.vNUgiS7H%fengguang.wu@intel.com> (raw)
In-Reply-To: <1470989940-3886-1-git-send-email-wanpeng.li@hotmail.com>

[-- Attachment #1: Type: text/plain, Size: 8186 bytes --]

Hi Wanpeng,

[auto build test WARNING on tip/sched/core]
[also build test WARNING on v4.8-rc1 next-20160811]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Wanpeng-Li/sched-deadline-Fix-the-intention-to-re-evalute-tick-dependency-for-offline-cpu/20160812-162528
config: x86_64-randconfig-x019-201632 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/uapi/linux/stddef.h:1:0,
                    from include/linux/stddef.h:4,
                    from include/uapi/linux/posix_types.h:4,
                    from include/uapi/linux/types.h:13,
                    from include/linux/types.h:5,
                    from include/uapi/linux/capability.h:16,
                    from include/linux/capability.h:15,
                    from include/linux/sched.h:15,
                    from kernel/sched/sched.h:2,
                    from kernel/sched/deadline.c:17:
   kernel/sched/deadline.c: In function 'dl_task_timer':
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   include/linux/compiler.h:125:14: note: in expansion of macro 'likely_notrace'
       ______r = likely_notrace(x);   \
                 ^~~~~~~~~~~~~~
   include/linux/compiler.h:139:58: note: in expansion of macro '__branch_check__'
    #  define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
                                                             ^~~~~~~~~~~~~~~~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:149:42: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                             ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   include/linux/compiler.h:125:14: note: in expansion of macro 'likely_notrace'
       ______r = likely_notrace(x);   \
                 ^~~~~~~~~~~~~~
   include/linux/compiler.h:139:58: note: in expansion of macro '__branch_check__'
    #  define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
                                                             ^~~~~~~~~~~~~~~~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~
   kernel/sched/deadline.c:644:18: error: 'struct rq' has no member named 'online'
     if (unlikely(!rq->online))
                     ^
   include/linux/compiler.h:160:16: note: in definition of macro '__trace_if'
      ______r = !!(cond);     \
                   ^~~~
>> kernel/sched/deadline.c:644:2: note: in expansion of macro 'if'
     if (unlikely(!rq->online))
     ^~
   include/linux/compiler.h:125:14: note: in expansion of macro 'likely_notrace'
       ______r = likely_notrace(x);   \
                 ^~~~~~~~~~~~~~
   include/linux/compiler.h:139:58: note: in expansion of macro '__branch_check__'
    #  define unlikely(x) (__builtin_constant_p(x) ? !!(x) : __branch_check__(x, 0))
                                                             ^~~~~~~~~~~~~~~~
   kernel/sched/deadline.c:644:6: note: in expansion of macro 'unlikely'
     if (unlikely(!rq->online))
         ^~~~~~~~

vim +/if +644 kernel/sched/deadline.c

   628		 *   schedule()
   629		 *     deactivate_task()
   630		 *       dequeue_task_dl()
   631		 *         update_curr_dl()
   632		 *           start_dl_timer()
   633		 *         __dequeue_task_dl()
   634		 *     prev->on_rq = 0;
   635		 *
   636		 * We can be both throttled and !queued. Replenish the counter
   637		 * but do not enqueue -- wait for our wakeup to do that.
   638		 */
   639		if (!task_on_rq_queued(p)) {
   640			replenish_dl_entity(dl_se, dl_se);
   641			goto unlock;
   642		}
   643	
 > 644		if (unlikely(!rq->online))
   645			replenish_dl_entity(dl_se, dl_se);
   646		else {
   647			enqueue_task_dl(rq, p, ENQUEUE_REPLENISH);
   648			if (dl_task(rq->curr))
   649				check_preempt_curr_dl(rq, p, 0);
   650			else
   651				resched_curr(rq);
   652		}

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/octet-stream, Size: 26211 bytes --]

      parent reply	other threads:[~2016-08-12  8:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-12  8:19 Wanpeng Li
2016-08-12  8:54 ` kbuild test robot
2016-08-12  8:57 ` kbuild test robot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201608121637.vNUgiS7H%fengguang.wu@intel.com \
    --to=lkp@intel.com \
    --cc=fweisbec@gmail.com \
    --cc=juri.lelli@arm.com \
    --cc=kbuild-all@01.org \
    --cc=kernellwp@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@unitn.it \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=wanpeng.li@hotmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®