From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752779AbcHLRYP (ORCPT ); Fri, 12 Aug 2016 13:24:15 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:48426 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752362AbcHLRYN (ORCPT ); Fri, 12 Aug 2016 13:24:13 -0400 X-IBM-Helo: d03dlp01.boulder.ibm.com X-IBM-MailFrom: arbab@linux.vnet.ibm.com Date: Fri, 12 Aug 2016 12:24:03 -0500 From: Reza Arbab To: Balbir Singh Cc: Rob Herring , Mark Rutland , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Jonathan Corbet , Bharata B Rao , Nathan Fontenot , devicetree@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] powerpc/mm: allow memory hotplug into a memoryless node References: <1470680843-28702-1-git-send-email-arbab@linux.vnet.ibm.com> <1470680843-28702-4-git-send-email-arbab@linux.vnet.ibm.com> <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <7d943111-d243-ffb3-ff5f-6d712c268e67@gmail.com> Organization: IBM Austin User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16081217-0016-0000-0000-000004686F66 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00005583; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000181; SDB=6.00743744; UDB=6.00350259; IPR=6.00516281; BA=6.00004660; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00012328; XFM=3.00000011; UTC=2016-08-12 17:24:10 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16081217-0017-0000-0000-000031F60694 Message-Id: <20160812172402.GA31526@arbab-vm.austin.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-08-12_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1604210000 definitions=main-1608120184 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 12, 2016 at 11:50:43AM +1000, Balbir Singh wrote: >On 09/08/16 04:27, Reza Arbab wrote: >> Remove the check which prevents us from hotplugging into an empty node. > >Do we want to do this only for ibm,hotplug-aperture compatible ranges? We could, but since past discussions and current testing have been unable to justify preventing hotplug to a memoryless node in the first place, I'm inclined to keep things simple. If some edge case is discovered, making it conditional as you describe will be a good solution. Thanks for your review! A v2 of this set is pending my investigation of Michael's suggestion to get node hotadd working. -- Reza Arbab