From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752847AbcHLTAg (ORCPT <rfc822;w@1wt.eu>);
	Fri, 12 Aug 2016 15:00:36 -0400
Received: from mail-oi0-f67.google.com ([209.85.218.67]:33025 "EHLO
	mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752583AbcHLTAd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 12 Aug 2016 15:00:33 -0400
Date: Fri, 12 Aug 2016 14:00:31 -0500
From: Rob Herring <robh@kernel.org>
To: Vignesh R <vigneshr@ti.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Mark Rutland <mark.rutland@arm.com>, Tony Lindgren <tony@atomide.com>,
        Russell King <linux@armlinux.org.uk>, Arnd Bergmann <arnd@arndb.de>,
        John Stultz <john.stultz@linaro.org>,
        S Twiss <stwiss.opensource@diasemi.com>,
        Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@linaro.org>,
        Moritz Fischer <moritz.fischer@ettus.com>,
        Daniel Hung-yu Wu <hywu@google.com>,
        Grant Grundler <grundler@chromium.org>, linux-input@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ARM: dts: am335x-icev2: Add nodes for gpio-decoder
Message-ID: <20160812190031.GA16954@rob-hp-laptop>
References: <20160812045229.29241-1-vigneshr@ti.com>
 <20160812045229.29241-3-vigneshr@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20160812045229.29241-3-vigneshr@ti.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Aug 12, 2016 at 10:22:29AM +0530, Vignesh R wrote:
> AM335x ICE board has a rotary-switch connected to PCA9536 I2C GPIO
> expander. The position of the rotary-switch is reflected by status of
> GPIO lines. Add gpio-decoder node to read these GPIO line status via
> gpio-decoder driver and report it as an input event to the system.
> 
> Signed-off-by: Vignesh R <vigneshr@ti.com>
> ---
>  arch/arm/boot/dts/am335x-icev2.dts | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/am335x-icev2.dts b/arch/arm/boot/dts/am335x-icev2.dts
> index 7d8b8fefdf08..f2de594343f2 100644
> --- a/arch/arm/boot/dts/am335x-icev2.dts
> +++ b/arch/arm/boot/dts/am335x-icev2.dts
> @@ -139,6 +139,15 @@
>  			default-state = "off";
>  		};
>  	};
> +	gpio-decoder0 {

Drop the 0 here.

> +		compatible = "gpio-decoder";
> +		gpios = <&pca9536 3 GPIO_ACTIVE_HIGH>,
> +			<&pca9536 2 GPIO_ACTIVE_HIGH>,
> +			<&pca9536 1 GPIO_ACTIVE_HIGH>,
> +			<&pca9536 0 GPIO_ACTIVE_HIGH>;
> +		linux,axis = <0>; /* ABS_X */
> +		gpio-decoder,max-value = <9>;
> +	};
>  };
>  
>  &am33xx_pinmux {
> -- 
> 2.9.2
>