From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753059AbcHLXoQ (ORCPT ); Fri, 12 Aug 2016 19:44:16 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:44997 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752487AbcHLXmf (ORCPT ); Fri, 12 Aug 2016 19:42:35 -0400 From: Suman Anna To: Bjorn Andersson CC: Ohad Ben-Cohen , , , Suman Anna Subject: [PATCH 09/13] rpmsg: remove pointless OOM prints Date: Fri, 12 Aug 2016 18:42:24 -0500 Message-ID: <20160812234228.39731-10-s-anna@ti.com> X-Mailer: git-send-email 2.9.0 In-Reply-To: <20160812234228.39731-1-s-anna@ti.com> References: <20160812234228.39731-1-s-anna@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org These types of error prints are superfluous. The system will pick up on OOM issues and let the user know. While at this, fix the usage of using a structure instead of the actual variable in one of the allocations. Signed-off-by: Suman Anna --- drivers/rpmsg/virtio_rpmsg_bus.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/rpmsg/virtio_rpmsg_bus.c b/drivers/rpmsg/virtio_rpmsg_bus.c index fe03b2aef450..1dbe756a987d 100644 --- a/drivers/rpmsg/virtio_rpmsg_bus.c +++ b/drivers/rpmsg/virtio_rpmsg_bus.c @@ -220,10 +220,8 @@ static struct rpmsg_endpoint *__rpmsg_create_ept(struct virtproc_info *vrp, struct device *dev = rpdev ? &rpdev->dev : &vrp->vdev->dev; ept = kzalloc(sizeof(*ept), GFP_KERNEL); - if (!ept) { - dev_err(dev, "failed to kzalloc a new ept\n"); + if (!ept) return NULL; - } kref_init(&ept->refcount); mutex_init(&ept->cb_lock); @@ -514,11 +512,9 @@ static struct rpmsg_channel *rpmsg_create_channel(struct virtproc_info *vrp, return NULL; } - rpdev = kzalloc(sizeof(struct rpmsg_channel), GFP_KERNEL); - if (!rpdev) { - pr_err("kzalloc failed\n"); + rpdev = kzalloc(sizeof(*rpdev), GFP_KERNEL); + if (!rpdev) return NULL; - } rpdev->vrp = vrp; rpdev->src = chinfo->src; -- 2.9.0