From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932369AbcHNI6Z (ORCPT ); Sun, 14 Aug 2016 04:58:25 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:35582 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752989AbcHNI6X (ORCPT ); Sun, 14 Aug 2016 04:58:23 -0400 Date: Sat, 13 Aug 2016 11:52:22 -0700 (PDT) Message-Id: <20160813.115222.443333178659469072.davem@davemloft.net> To: appana.durga.rao@xilinx.com Cc: robh+dt@kernel.org, mark.rutland@arm.com, nicolas.ferre@atmel.com, sergio.prado@e-labworks.com, gregory.clement@free-electrons.com, narmstrong@baylibre.com, michal.simek@xilinx.com, appanad@xilinx.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: macb: add phy-handle support for the macb From: David Miller In-Reply-To: <1471082509-11764-1-git-send-email-appanad@xilinx.com> References: <1471082509-11764-1-git-send-email-appanad@xilinx.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 13 Aug 2016 11:52:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kedareswara rao Appana Date: Sat, 13 Aug 2016 15:31:49 +0530 > @@ -445,7 +445,13 @@ static int macb_mii_init(struct macb *bp) > dev_set_drvdata(&bp->dev->dev, bp->mii_bus); > > np = bp->pdev->dev.of_node; > - if (np) { > + np1 = of_get_parent(bp->phy_node); > + if (np1) { > + of_node_put(np1); > + err = of_mdiobus_register(bp->mii_bus, np1); > + if (err) > + goto err_out_unregister_bus; > + } else if (np) { I don't know about this, all OF nodes other than the root have a parent node which is non-NULL. This parent node can be anything. Just blinding assuming that any parent node of the phy_node is what we are looking for, without any other supplementary checks at all, seems to be asking for trouble at the very least.