From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752595AbcHOEdR convert rfc822-to-8bit (ORCPT ); Mon, 15 Aug 2016 00:33:17 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:39455 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752315AbcHOEdQ (ORCPT ); Mon, 15 Aug 2016 00:33:16 -0400 Date: Sun, 14 Aug 2016 21:33:15 -0700 (PDT) Message-Id: <20160814.213315.1476217194881057932.davem@davemloft.net> To: vincent.stehle@laposte.net Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, jiri@mellanox.com Subject: Re: [PATCH] mlxsw: spectrum_router: Fix use after free From: David Miller In-Reply-To: <1471181909-22187-1-git-send-email-vincent.stehle@laposte.net> References: <1471181909-22187-1-git-send-email-vincent.stehle@laposte.net> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 14 Aug 2016 21:33:15 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vincent Stehlé Date: Sun, 14 Aug 2016 15:38:29 +0200 > In mlxsw_sp_router_fib4_add_info_destroy(), the fib_entry pointer is used > after it has been freed by mlxsw_sp_fib_entry_destroy(). Use a temporary > variable to fix this. > > Fixes: 61c503f976b5449e ("mlxsw: spectrum_router: Implement fib4 add/del switchdev obj ops") > Signed-off-by: Vincent Stehlé > Cc: Jiri Pirko Applied.