From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752859AbcHOIb2 (ORCPT ); Mon, 15 Aug 2016 04:31:28 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:33360 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752377AbcHOIbC (ORCPT ); Mon, 15 Aug 2016 04:31:02 -0400 Date: Mon, 15 Aug 2016 11:30:53 +0300 From: Johan Hedberg To: Nicolas Iooss Cc: Marcel Holtmann , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] Bluetooth: add printf format attribute to hci_set_[fh]w_info() Message-ID: <20160815083053.GA32660@t440s.lan> Mail-Followup-To: Nicolas Iooss , Marcel Holtmann , linux-bluetooth@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20160729112825.22091-1-nicolas.iooss_linux@m4x.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160729112825.22091-1-nicolas.iooss_linux@m4x.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Nicolas, On Fri, Jul 29, 2016, Nicolas Iooss wrote: > Commit 5177a83827cd ("Bluetooth: Add debugfs fields for hardware and > firmware info") introduced hci_set_hw_info() and hci_set_fw_info(). > These functions use kvasprintf_const() but are not marked with a > __printf attribute. Adding such an attribute helps detecting issues > related to printf-formatting at build time. > > Signed-off-by: Nicolas Iooss > --- > include/net/bluetooth/hci_core.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to bluetooth-next. Thanks. Johan